You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/08/12 14:32:53 UTC
[GitHub] [lucene-solr] cpoerschke opened a new pull request #1745: Append MultiCollectorTest to TestMultiCollector.
cpoerschke opened a new pull request #1745:
URL: https://github.com/apache/lucene-solr/pull/1745
As part of https://issues.apache.org/jira/browse/LUCENE-8626 I noticed that `MultiCollector` has two tests. This pull request proposes to unify them into one test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1745: Append MultiCollectorTest to TestMultiCollector.
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1745:
URL: https://github.com/apache/lucene-solr/pull/1745#issuecomment-674940365
Awesome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1745: Append MultiCollectorTest to TestMultiCollector.
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1745:
URL: https://github.com/apache/lucene-solr/pull/1745#issuecomment-674778734
> Was this a straight copy from one class to the other? ...
Yes, I did `cat $oneFile >> $otherFile` and then in the IDE stripped out the middle duplicate license and import bits, adding extra imports at the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke merged pull request #1745: Append MultiCollectorTest to TestMultiCollector.
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #1745:
URL: https://github.com/apache/lucene-solr/pull/1745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org