You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/08/24 22:36:48 UTC

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #68: LOGCXX-431

rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695263225



##########
File path: src/main/cpp/asyncappender.cpp
##########
@@ -50,7 +51,7 @@ AsyncAppender::AsyncAppender()
 	  locationInfo(false),
 	  blocking(true)
 {
-	dispatcher = std::thread( &AsyncAppender::dispatch, this );
+	dispatcher = ThreadUtility::instance()->createThread( LOG4CXX_STR("AyncAppend"), &AsyncAppender::dispatch, this );

Review comment:
       On Linux at least, the thread name is limited to [16 characters](https://man7.org/linux/man-pages/man3/pthread_setname_np.3.html), so I wanted to keep the names as short as possible.  At least in this case, there's enough space to do 'AsyncAppender'. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org