You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/08/01 20:37:17 UTC
[GitHub] incubator-pirk pull request #42: [PIRK-41]: Add JSON Serialization for Java ...
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/42
[PIRK-41]: Add JSON Serialization for Java Objects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-pirk PIRK-41
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 7f934c7961c978fa907a724c2a223ab800ed9dd4
Author: smarthi <sm...@apache.org>
Date: 2016-08-01T20:36:49Z
[PIRK-41]: Add JSON Serialization for Java Objects
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #42: [PIRK-41]: Add JSON Serialization for Java Objects
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/42
Added very basic simple tests for Java and Json Serializers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #42: [PIRK-41]: Add JSON Serialization for Java Objects
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/42
Thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #42: [PIRK-41]: Add JSON Serialization for Java Objects
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/42
I was debating if I shuld do that as part of this PR or not. I'll go ahead
and do it.
On Mon, Aug 1, 2016 at 4:59 PM, ellisonanne <no...@github.com>
wrote:
> Hi Suneel - How did you test this? We should include quick/simple unit
> tests for all custom SerializationServices.
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pirk/pull/42#issuecomment-236705920>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC_fojyOhTLp9zX6gXxmh6CBHU-waQ1Cks5qbl4fgaJpZM4JZ-NN>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #42: [PIRK-41]: Add JSON Serialization for Java Objects
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/42
Hi Suneel - How did you test this? We should include quick/simple unit tests for all custom SerializationServices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #42: [PIRK-41]: Add JSON Serialization for Java ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #42: [PIRK-41]: Add JSON Serialization for Java Objects
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/42
+1 looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---