You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/05/21 08:34:10 UTC

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2593: sys/stats: Fix build warnings when stats are stubbed

kasjer commented on a change in pull request #2593:
URL: https://github.com/apache/mynewt-core/pull/2593#discussion_r636739180



##########
File path: hw/bus/src/bus.c
##########
@@ -246,11 +246,11 @@ bus_dev_init_func(struct os_dev *odev, void *arg)
 
 #if MYNEWT_VAL(BUS_STATS)
     asprintf(&stats_name, "bd_%s", odev->od_name);
-    /* XXX should we assert or return error on failure? */
-    stats_init_and_reg(STATS_HDR(bdev->stats),
-                       STATS_SIZE_INIT_PARMS(bdev->stats, STATS_SIZE_32),
-                       STATS_NAME_INIT_PARMS(bus_stats_section),
-                       stats_name);
+    rc = stats_init_and_reg(STATS_HDR(bdev->stats),

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org