You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tirkarthi (via GitHub)" <gi...@apache.org> on 2024/12/03 13:21:15 UTC
[I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
tirkarthi opened a new issue, #44606:
URL: https://github.com/apache/airflow/issues/44606
Also this just makes me realize that `http://localhost:29091/ui/dags/recent_dag_runs?dag_id_pattern=xxxxx` endpoint should most certainly also support a `dag_id` query params or `dag_ids`.
I am affraid that using a `pattern` like this could end up matching multiple dags while we are really trying to get the dag_runs from a specific dag like here.
_Originally posted by @pierrejeambrun in https://github.com/apache/airflow/issues/44074#issuecomment-2482613859_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on issue #44606:
URL: https://github.com/apache/airflow/issues/44606#issuecomment-2519858054
Indeed, now with the refactoring we have tools to achieve that. We still need to add this capability though, so we can close it.
It's quite straightforward with the new parameter system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on issue #44606:
URL: https://github.com/apache/airflow/issues/44606#issuecomment-2514580657
Nice thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on issue #44606:
URL: https://github.com/apache/airflow/issues/44606#issuecomment-2514563829
Opened this issue for tracking as it got lost in the PR review. It seems there is `QueryDagIdsFilter` in `get_dag_stats` but it's a GET endpoint and multiple `dag_ids` query parameter can be passed and there is no standard for this.
https://stackoverflow.com/questions/24059773/correct-way-to-pass-multiple-values-for-same-parameter-name-in-get-request
https://github.com/apache/airflow/blob/edf3e3376811129a9fad278ae396b3b5644c69d8/airflow/api_fastapi/core_api/routes/public/dag_stats.py#L40-L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed issue #44606: Add support to filter by dag_id in recent_dag_runs endpoint
URL: https://github.com/apache/airflow/issues/44606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support to filter by dag_id in recent_dag_runs endpoint [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on issue #44606:
URL: https://github.com/apache/airflow/issues/44606#issuecomment-2518993256
Hi @tirkarthi , I think this issue is resolve after https://github.com/apache/airflow/pull/44345 is merged:
https://github.com/apache/airflow/blob/main/airflow/api_fastapi/core_api/routes/public/dag_stats.py#L56-L61
After the refactor, we can leverage `FilterParam` and `filter_param_factory` for query parameters with simple logic. By passing `list[str]` to `_type`, we can standardize the format of request query parameters using FastAPI's native features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org