You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/05/01 02:17:45 UTC

Review Request 20930: Patch for KAFKA-1433

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20930/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1433
    https://issues.apache.org/jira/browse/KAFKA-1433


Repository: kafka


Description
-------

1. Standardize all unit tests to use TestUtils.createProducer. 2. Increased the retry time in to TestUtils.createProducer. 3. Set # retries to 0 for all unit tests that expect the producer send to fail.


Diffs
-----

  core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 40a25a29cd6dbaa2a4df0c0b0f149205d3e7b544 
  core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 97e3b1454457bdc8d31ee24b0edf85c85b815d55 
  core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 6c3feacfb5ead7222e7f7962688894c4e9e886aa 
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala c3da69d3c2ef7b3bf276e3b748b5c213980a0e10 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 384c74e7c3985abff864e61dea5e530dbd189d5d 

Diff: https://reviews.apache.org/r/20930/diff/


Testing
-------


Thanks,

Jun Rao

Re: Review Request 20930: Patch for KAFKA-1433

Posted by Guozhang Wang <gu...@linkedin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20930/#review41918
-----------------------------------------------------------

Ship it!



core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
<https://reviews.apache.org/r/20930/#comment75572>

    stringProducer1 => stringProducer


- Guozhang Wang


On May 1, 2014, 12:17 a.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20930/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 12:17 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1433
>     https://issues.apache.org/jira/browse/KAFKA-1433
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> 1. Standardize all unit tests to use TestUtils.createProducer. 2. Increased the retry time in to TestUtils.createProducer. 3. Set # retries to 0 for all unit tests that expect the producer send to fail.
> 
> 
> Diffs
> -----
> 
>   core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 40a25a29cd6dbaa2a4df0c0b0f149205d3e7b544 
>   core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 97e3b1454457bdc8d31ee24b0edf85c85b815d55 
>   core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 6c3feacfb5ead7222e7f7962688894c4e9e886aa 
>   core/src/test/scala/unit/kafka/producer/ProducerTest.scala c3da69d3c2ef7b3bf276e3b748b5c213980a0e10 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 384c74e7c3985abff864e61dea5e530dbd189d5d 
> 
> Diff: https://reviews.apache.org/r/20930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>