[jira] Resolved: (HARMONY-5695) [classlib][nio_char] speed up of Charset.forNameInternal

["Tim Ellison (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-5695.
----------------------------------

    Resolution: Fixed

Thanks Alexei.

Patch applied to NIO_CHAR module at repo revision r698500.

Please check it was applied as you expected.

I suppose an additional enhancement would be to make the cache a concurrent hash map, and move the name validity checking out of the synchronized block.

> [classlib][nio_char] speed up of Charset.forNameInternal
> --------------------------------------------------------
>
>                 Key: HARMONY-5695
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5695
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Tim Ellison
>         Attachments: changes.patch, charset_cache_opt.patch, formatting.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The excessive validity check prepends cache access. The solution is to put the check after cache access.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.