You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by josephw <gi...@git.apache.org> on 2015/02/21 07:41:43 UTC
[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...
GitHub user josephw opened a pull request:
https://github.com/apache/maven/pull/37
MNG-5734: Fail, rather than just warning, on empty '<module>' entries.
An incorrect non-blank module is currently treated as an error. Behave
the same way for a blank module, rather than simply warning about
the mistake.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephw/maven MNG-5734-fail-on-empty-modules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 8474aa5b37e455e5be90414a401ca563af7470c2
Author: Joseph Walton <jo...@kafsemo.org>
Date: 2015-02-21T06:33:01Z
MNG-5734: Fail, rather than just warning, on empty '<module>' entries.
An incorrect non-blank module is currently treated as an error. Behave
the same way for a blank module, rather than simply warning about
the mistake.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/37#issuecomment-75374322
I think this is reasonable, it should fail instead as it's incorrect. Anyone have an issue merging this. All the ITs pass here so if there are no objections today I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...
Posted by josephw <gi...@git.apache.org>.
Github user josephw closed the pull request at:
https://github.com/apache/maven/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5734: Fail, rather than just warning, on e...
Posted by khmarbaise <gi...@git.apache.org>.
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/37#issuecomment-75376033
I would vote +1 for this ...;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org