You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/04/05 15:42:39 UTC

[kudu-CR](branch-1.17.x) [Python] Add support for immutable column

Hello Alexey Serbin, Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/19695

to review the following change.


Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Reviewed-on: http://gerrit.cloudera.org:8080/19586
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/19695/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19695
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.17.x) [Python] Add support for immutable column

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19695 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19695
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:22:50 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [Python] Add support for immutable column

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19695 )

Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Reviewed-on: http://gerrit.cloudera.org:8080/19586
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19695
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19695
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>