You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/15 18:12:58 UTC
[jira] [Commented] (CAMEL-10511) MllpTcpClientProducer should read
all available bytes in TCP buffer for acknowledgment
[ https://issues.apache.org/jira/browse/CAMEL-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752068#comment-15752068 ]
ASF GitHub Bot commented on CAMEL-10511:
----------------------------------------
GitHub user hqstevenson opened a pull request:
https://github.com/apache/camel/pull/1351
CAMEL-10511: Updated MllpTcpClientProducer and MllpTcpServerConsumer…
… to consume all available data on socket
This turned out to be a pretty major refactor. I also found and corrected numerous issues with corner cases in the TCP error handling.
The test suite is much more complete now as well
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hqstevenson/camel CAMEL-10511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1351
----
commit 340847a0bb152239cb44925793d93ff8d00d784b
Author: Quinn Stevenson <qu...@pronoia-solutions.com>
Date: 2016-12-06T19:23:03Z
CAMEL-10511: Updated MllpTcpClientProducer and MllpTcpServerConsumer to consume all available data on socket
----
> MllpTcpClientProducer should read all available bytes in TCP buffer for acknowledgment
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-10511
> URL: https://issues.apache.org/jira/browse/CAMEL-10511
> Project: Camel
> Issue Type: Bug
> Components: camel-mllp
> Affects Versions: 2.17.0
> Reporter: Quinn Stevenson
> Assignee: Quinn Stevenson
> Priority: Minor
>
> The MllpClientProducer currently reads the TCP buffer until it receives the proper closing frame characters for the MLLP envelope.
> This turned out to be a problem with a certain MLLP Server, which under certain circumstances would send double MLLP acknowledgments. As currently written, the MllpClientProducer will use the old/double/second acknowledgment for the next message - which may cause erroneous results, but in any case is clearly wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)