[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5669: Fixing code to fetch the fsConfig from the right parent

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #5669:
URL: https://github.com/apache/incubator-pinot/pull/5669#discussion_r451902715



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java
##########
@@ -60,19 +60,19 @@ public static void register(String scheme, String fsClassName, PinotConfiguratio
     }
   }
 
-  public static void init(PinotConfiguration fsConfig) {
+  public static void init(PinotConfiguration config) {

Review comment:
       I see all non-test callers of this api are calling it with fsConfig. Is that expected? Would be good to add javadoc based on what we find.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org