You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/11 23:38:30 UTC

[GitHub] junrushao1994 commented on a change in pull request #14018: [MXNET-1315] Add checks for dynamic-shaped operators in CachedOp

junrushao1994 commented on a change in pull request #14018: [MXNET-1315] Add checks for dynamic-shaped operators in CachedOp
URL: https://github.com/apache/incubator-mxnet/pull/14018#discussion_r255742485
 
 

 ##########
 File path: src/operator/subgraph_op_common.cc
 ##########
 @@ -222,8 +222,12 @@ void LoopState::Forward(int iter_no,
   // If an input and an output share the array, the output array will be changed
   // by CachedOp. We need to copy data to the real output.
   for (size_t i = 0; i < out_bufs.size(); i++)
-    if (!out_bufs[i].IsSame(coutputs[i]))
+    if (!out_bufs[i].IsSame(coutputs[i])) {
 
 Review comment:
   Sure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services