You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/06 19:30:00 UTC

[GitHub] [calcite] julianhyde commented on issue #1503: [CALCITE-3408] Add support for enumerable intersect/minus all

julianhyde commented on issue #1503: [CALCITE-3408] Add support for enumerable intersect/minus all
URL: https://github.com/apache/calcite/pull/1503#issuecomment-550464667
 
 
   I think you should keep the old methods, not deprecated. Treat 'all' as an optional parameter whose default is false.
   
   Overloaded methods with different parameters should have different javadoc descriptions. It was an oversight not to change the description when you added the 'all' parameter. Can you fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services