[GitHub] [maven-wrapper] hazendaz commented on a diff in pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

[GitBox <gi...@apache.org>]

hazendaz commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r913267565


##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -192,7 +192,8 @@ else
       wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"
     fi
     while IFS="=" read key value; do
-      case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+      # Remove invalid line endings from value
+      case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   @michael-o When you get a chance, can you check in on this again?  Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org