You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Paulo Motta (Jira)" <ji...@apache.org> on 2023/03/06 23:15:00 UTC
[jira] [Created] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
Paulo Motta created CASSANDRA-18304:
---------------------------------------
Summary: hinted_handoff_enabled=false is not honored
Key: CASSANDRA-18304
URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
Project: Cassandra
Issue Type: Bug
Components: Consistency/Hints
Reporter: Paulo Motta
Assignee: Paulo Motta
I've had some dtests with disabled hints failing.
After investigation it seems that CASSANDRA-17164 moved hint submission on timeout from [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176] to [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285], but it no longer checks if {{CallbackInfo.shouldHint}} which checks for {{StorageProxy.shouldHint}} which ultimately checks if {{{}hinted_handoff_enabled=true{}}}.
This could cause some tests which expect hints to be disabled to fail intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org