You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2011/05/19 20:44:47 UTC
[jira] [Created] (HIVE-2171) Allow custom serdes to set field
comments
Allow custom serdes to set field comments
-----------------------------------------
Key: HIVE-2171
URL: https://issues.apache.org/jira/browse/HIVE-2171
Project: Hive
Issue Type: Improvement
Reporter: Jakob Homan
Assignee: Jakob Homan
Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HIVE-2171:
------------------------------
Status: Patch Available (was: Open)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2171:
-------------------------------
Status: Open (was: Patch Available)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084349#comment-13084349 ]
John Sichi commented on HIVE-2171:
----------------------------------
BTW, I noticed that the mockito jar ends up in build/dist lib (similar to junit). Does that mean we also need to add a license notice for it?
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.8.0
>
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2171:
-----------------------------
Status: Open (was: Patch Available)
I tried applying the patch against trunk for testing, but hit some conflicts...can you rebase?
Also, @Yongqiang: do you have any more comments on this one?
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079136#comment-13079136 ]
jiraposter@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------
(Updated 2011-08-04 00:12:21.542815)
Review request for hive.
Changes
-------
Updated patch based on review comments.
Summary
-------
HIVE-2171: Allow custom serdes to set field comments
This addresses bug HIVE-2171.
https://issues.apache.org/jira/browse/HIVE-2171
Diffs (updated)
-----
ivy/libraries.properties af856bd
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5
serde/ivy.xml d6c836a
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 4850601
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java e2fa9db
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java 2947e49
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java 3d5408f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java 881c3c1
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java bd42a0c
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 0c8cc42
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java 4a934c5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java 3b26e45
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java 76ff736
serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java f139ea5
Diff: https://reviews.apache.org/r/790/diff
Testing
-------
New unit test and refactor existing unit test.
Thanks,
Jakob
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072635#comment-13072635 ]
John Sichi commented on HIVE-2171:
----------------------------------
I'll take a look.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060805#comment-13060805 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
bq. And can we modify the desc table commands to show comments from StorageDescriptor, instead of putting a "from deserializer"?
I opened HIVE-2189 for this issue.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041754#comment-13041754 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
Anything else necessary to get a review on this patch?
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HIVE-2171:
------------------------------
Attachment: HIVE-2171-2.patch
Updated patch.
* rebased against trunk
* added braces around all new if statements
* checked for checkstyle errors, didn't see any, although it's difficult to be sure since there is a baseline of 4,789 violations in trunk.
Do I need to open a new RB for this updated patch? Do the committers run the full test suite? I see lots of comments like "will commit if tests pass." Does this mean that in Hive it's up to the committers to do the testing? Thanks.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082588#comment-13082588 ]
jiraposter@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------
(Updated 2011-08-10 19:24:16.187507)
Review request for hive and John Sichi.
Changes
-------
updated patch based on review comments.
Summary
-------
HIVE-2171: Allow custom serdes to set field comments
This addresses bug HIVE-2171.
https://issues.apache.org/jira/browse/HIVE-2171
Diffs
-----
ivy/libraries.properties af856bd
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5
serde/ivy.xml d6c836a
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 4850601
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java e2fa9db
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java 2947e49
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java 3d5408f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java 881c3c1
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java bd42a0c
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 0c8cc42
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java 4a934c5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java 3b26e45
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java 76ff736
serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java f139ea5
Diff: https://reviews.apache.org/r/790/diff
Testing
-------
New unit test and refactor existing unit test.
Thanks,
Jakob
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084354#comment-13084354 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
Quite likely. I'll investigate and open a JIRA. Thanks.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.8.0
>
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084491#comment-13084491 ]
Hudson commented on HIVE-2171:
------------------------------
Integrated in Hive-trunk-h0.21 #892 (See [https://builds.apache.org/job/Hive-trunk-h0.21/892/])
HIVE-2171. Allow custom serdes to set field comments
(Jakob Homan via jvs)
jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157224
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
* /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
* /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
* /hive/trunk/ivy/libraries.properties
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java
* /hive/trunk/serde/ivy.xml
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.8.0
>
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2171:
---------------------------------
Fix Version/s: (was: 0.7.1)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HIVE-2171:
------------------------------
Attachment: HIVE-2171.patch
Patch:
* Adds comment field to StructField interface and implements reasonable versions to each of its implementations.
* Adds overloaded versions of each of the struct-based ObjectInspector factories to allow the comments to be set.
* Adjusts MetastoreUtils to check if the comment of the field is null, if so, maintains previous behavior, else uses the comment.
* Adds new unit test for MetastoreUtils. For this, mockito was added as a dependency. Right now it looks like Hive's Ivy conf isn't set up to only include some jars in the package. If this patch goes in, I'll open another jira to make sure the mockito and other test-related jars aren't included in jars they don't need to be.
* Refactors the TestStandardObjectInspectors test to test both with and without comments.
After this patch, a serde that wants to specify comments can and have them show up in the table description. For example, with a table kst created by an implementation of SerDe, that has an example for each type (the comments are all separate, they're all just boring: this is field BLAH) can now set the field comments:
{noformat}hive> describe kst;
OK
string1 string this field is string1
string2 string this field is string2
int1 int this field is int1
boolean1 boolean this field is boolean1
long1 bigint this field is long1
float1 float this field is float1
double1 double this field is double1
inner_record1 struct<int_in_inner_record1:int,string_in_inner_record1:string> this field is inner_record1
enum1 string this field is enum1
array1 array<string> this field is array1
map1 map<string,string> this field is map1
union1 uniontype<float,boolean,string> this field is union1
fixed1 array<tinyint> this field is fixed1
null1 void this field is null1
unionnullint int this field is UnionNullInt
bytes1 array<tinyint> this field is bytes1
ds string
Time taken: 0.286 seconds{noformat}
One thing I noticed is that these field comments on structs should extended to substructures, and does with this new patch for custom serdes:
{noformat}hive> describe kst.inner_record1;
OK
int_in_inner_record1 int this field is int_in_inner_record1
string_in_inner_record1 string this field is string_in_inner_record1
Time taken: 0.113 seconds{noformat}
However, this doesn't work correctly with built-in serdes:
{noformat}hive> create table test_table(a STRUCT<z:string COMMENT 'comment for z',x:int> COMMENT 'comment for a');
OK
Time taken: 2.565 seconds
hive> describe test_table;
OK
a struct<z:string,x:int> comment for a
Time taken: 0.139 seconds
hive> describe test_table.a;
OK
z string from deserializer
x int from deserializer
Time taken: 0.096 seconds
hive> describe test_table.a.z;
OK
z string from deserializer
Time taken: 0.089 seconds
hive>{noformat}
The comment for field z is lost, replaced by the boilerplate text "from deserializer" and can't be retrieved from the CLI. I'll open a JIRA for this.
This is my first Hive patch, so please check to see if I missed anything.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043057#comment-13043057 ]
He Yongqiang commented on HIVE-2171:
------------------------------------
hive already stores each column's comment in StorageDescriptor. Can we get the comments from there instead of putting it to StructField?
And can we modify the desc table commands to show comments from StorageDescriptor, instead of putting a "from deserializer"?
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065759#comment-13065759 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
Is there anything else that needs to be done to get a code review on this patch?
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039900#comment-13039900 ]
jiraposter@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------
Review request for hive.
Summary
-------
HIVE-2171: Allow custom serdes to set field comments
This addresses bug HIVE-2171.
https://issues.apache.org/jira/browse/HIVE-2171
Diffs
-----
ivy/libraries.properties af856bd
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5
serde/ivy.xml d6c836a
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 4850601
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java e2fa9db
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java 2947e49
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java 3d5408f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java 66f4f8d
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java bd42a0c
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 90561a1
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java 4a934c5
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java 3b26e45
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java 76ff736
serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java f139ea5
Diff: https://reviews.apache.org/r/790/diff
Testing
-------
New unit test and refactor existing unit test.
Thanks,
Jakob
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HIVE-2171:
------------------------------
Fix Version/s: 0.7.1
Affects Version/s: 0.7.0
Status: Patch Available (was: Open)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.7.1
>
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079138#comment-13079138 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
I did do the intersection and didn't see anything. I've got tests going, but don't expect anything new as the review comments were about style rather than logic. The was relatively simple, so I'm not overly concerned about new problems introduced in the interim. Updated RB; some of the changes it shows for patch v1 to v2 are spurious and introduced by the trunk drift. Thanks.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079135#comment-13079135 ]
John Sichi commented on HIVE-2171:
----------------------------------
* Yes, please update RB
* checkstyle: yeah, I think what people do is intersect the list of files they changed with the report output
* test suite: yes, committers run the full suite and reject if anything fails, but it's best if authors do too (takes hours these days, so kick it off before you go to bed)
(And yes, we have ideas for improving all three of these inefficiencies, but so far no owners.)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078541#comment-13078541 ]
jiraposter@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/#review1274
-----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/790/#comment2908>
Use curly brackets for all if statements (even when the body only has one line). Use ant checkstyle to find more of these.
- John
On 2011-05-26 20:16:20, Jakob Homan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/790/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-26 20:16:20)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HIVE-2171: Allow custom serdes to set field comments
bq.
bq.
bq. This addresses bug HIVE-2171.
bq. https://issues.apache.org/jira/browse/HIVE-2171
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ivy/libraries.properties af856bd
bq. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5
bq. serde/ivy.xml d6c836a
bq. serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 4850601
bq. serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java e2fa9db
bq. serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java 2947e49
bq. serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java 3d5408f
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java 66f4f8d
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java bd42a0c
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 90561a1
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java 4a934c5
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java 3b26e45
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017
bq. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java 76ff736
bq. serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION
bq. serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java f139ea5
bq.
bq. Diff: https://reviews.apache.org/r/790/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New unit test and refactor existing unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Jakob
bq.
bq.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060219#comment-13060219 ]
Jakob Homan commented on HIVE-2171:
-----------------------------------
bq. hive already stores each column's comment in StorageDescriptor. Can we get the comments from there instead of putting it to StructField?
Hive stores column information for native serdes (see [SerDeUtils.java:99|https://github.com/apache/hive/blob/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L1889]). For non-native serdes, it queries the serde's object inspector, which is what this patch is dealing with.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083907#comment-13083907 ]
John Sichi commented on HIVE-2171:
----------------------------------
+1. Will commit when tests pass.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HIVE-2171:
------------------------------
Status: Patch Available (was: Open)
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2171) Allow custom serdes to set field
comments
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2171:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Jakob!
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.8.0
>
> Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment. These are set in the metastore utils to {{(from deserializer)}}. For those serdes that can provide meaningful comments for a field, they should be propagated to the table description. These serde-provided comments could be prepended to "(from deserializer)" if others feel that's a meaningful distinction. This change involves updating {{StructField}} to support a (possibly null) comment field and then propagating this change out to the myriad places {{StructField}} is thrown around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira