You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/14 02:47:49 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3714: Don't include debug.h from public header file

xiaoxiang781216 opened a new pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714


   ## Summary
   
   ## Impact
   Minor change
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-846704398


   >Please ignore the following nxstyle error:
   
   OK but the CI still failed.
   
   
   ```
   ====================================================================================
   Configuration/Tool: stm32f103-minimum/mcp2515,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
     Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
     Building NuttX...
   canlib_getbaud.c: In function 'canlib_getbaud':
   Error: canlib_getbaud.c:75:7: error: implicit declaration of function 'canerr'; did you mean 'clearerr'? [-Werror=implicit-function-declaration]
      75 |       canerr("CANIOC_GET_BITTIMING failed, errno=%d\n", errno);
         |       ^~~~~~
         |       clearerr
   cc1: all warnings being treated as errors
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#discussion_r642483265



##########
File path: fs/littlefs/Make.defs
##########
@@ -31,11 +31,10 @@ CSRCS += lfs.c lfs_util.c
 DEPPATH += --dep-path littlefs/littlefs
 VPATH += :littlefs/littlefs
 
-CFLAGS += -DLFS_TRACE=finfo
-CFLAGS += -DLFS_DEBUG=finfo
-CFLAGS += -DLFS_WARN=fwarn
-CFLAGS += -DLFS_ERROR=ferr
-CFLAGS += -DLFS_ASSERT=DEBUGASSERT
+CFLAGS += -DLFS_NO_ASSERT
+CFLAGS += -DLFS_NO_DEBUG
+CFLAGS += -DLFS_NO_ERROR
+CFLAGS += -DLFS_NO_WARN

Review comment:
       I take another approach by utilizing LFS_CONFIG hook.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#discussion_r642483265



##########
File path: fs/littlefs/Make.defs
##########
@@ -31,11 +31,10 @@ CSRCS += lfs.c lfs_util.c
 DEPPATH += --dep-path littlefs/littlefs
 VPATH += :littlefs/littlefs
 
-CFLAGS += -DLFS_TRACE=finfo
-CFLAGS += -DLFS_DEBUG=finfo
-CFLAGS += -DLFS_WARN=fwarn
-CFLAGS += -DLFS_ERROR=ferr
-CFLAGS += -DLFS_ASSERT=DEBUGASSERT
+CFLAGS += -DLFS_NO_ASSERT
+CFLAGS += -DLFS_NO_DEBUG
+CFLAGS += -DLFS_NO_ERROR
+CFLAGS += -DLFS_NO_WARN

Review comment:
       I take another approach by utilizing LFS_CONFIG hook. @masayuki2009 please take a look.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-851236618


   Ping @masayuki2009 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-851694395


   LGTM
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-846444297


   Depends on: https://github.com/apache/incubator-nuttx-apps/pull/726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-846839641


   Depends on: https://github.com/apache/incubator-nuttx-apps/pull/732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-851236618


   Ping @masayuki2009 or @jerpelea could you help review this minor change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-847113380


   @masayuki2009 all check execpt nxstyle pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#issuecomment-846429574


   Please ignore the following nxstyle error:
   ```
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:361:2: error: Mixed case identifier found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:370:2: error: Mixed case identifier found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:381:2: error: Mixed case identifier found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:390:2: error: Mixed case identifier found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/nrf52/nrf52_sdc.c:399:2: error: Mixed case identifier found
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #3714: Don't include debug.h from public header file

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#discussion_r642347338



##########
File path: fs/littlefs/Make.defs
##########
@@ -31,11 +31,10 @@ CSRCS += lfs.c lfs_util.c
 DEPPATH += --dep-path littlefs/littlefs
 VPATH += :littlefs/littlefs
 
-CFLAGS += -DLFS_TRACE=finfo
-CFLAGS += -DLFS_DEBUG=finfo
-CFLAGS += -DLFS_WARN=fwarn
-CFLAGS += -DLFS_ERROR=ferr
-CFLAGS += -DLFS_ASSERT=DEBUGASSERT
+CFLAGS += -DLFS_NO_ASSERT
+CFLAGS += -DLFS_NO_DEBUG
+CFLAGS += -DLFS_NO_ERROR
+CFLAGS += -DLFS_NO_WARN

Review comment:
       @xiaoxiang781216 
   
   I think we should create a separate PR for these changes.
   What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org