You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/10/02 22:45:54 UTC

[jira] [Commented] (HBASE-9598) Non thread safe increment of task.unforcedResubmits in SplitLogManager#resubmit()

    [ https://issues.apache.org/jira/browse/HBASE-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784408#comment-13784408 ] 

Hudson commented on HBASE-9598:
-------------------------------

FAILURE: Integrated in HBase-TRUNK #4584 (See [https://builds.apache.org/job/HBase-TRUNK/4584/])
HBASE-9598 Non thread safe increment of task.unforcedResubmits in SplitLogManager#resubmit() (tedyu: rev 1528568)
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java


> Non thread safe increment of task.unforcedResubmits in SplitLogManager#resubmit()
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-9598
>                 URL: https://issues.apache.org/jira/browse/HBASE-9598
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 9598-v1.txt, 9598-v2.txt
>
>
> In SplitLogManager#resubmit():
> {code}
>     if (directive != FORCE) {
>       task.unforcedResubmits++;
>     }
> {code}
> task.unforcedResubmits is volatile but the above increment doesn't have proper synchronization.



--
This message was sent by Atlassian JIRA
(v6.1#6144)