You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/01/06 08:39:27 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #993: ORC-1077: Remove commons-codec dependency and use java.util.Base64

dongjoon-hyun opened a new pull request #993:
URL: https://github.com/apache/orc/pull/993


   ### What changes were proposed in this pull request?
   
   This PR aims to remove `commons-codec` dependency and use `java.util.Base64`.
   
   ### Why are the changes needed?
   
   Java version is faster.
   - http://java-performance.info/base64-encoding-and-decoding-performance/
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #993: ORC-1077: Remove commons-codec dependency and use java.util.Base64

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #993:
URL: https://github.com/apache/orc/pull/993


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #993: ORC-1077: Remove commons-codec dependency and use java.util.Base64

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #993:
URL: https://github.com/apache/orc/pull/993#issuecomment-1006401468


   LGTM 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #993: ORC-1077: Remove commons-codec dependency and use java.util.Base64

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #993:
URL: https://github.com/apache/orc/pull/993#issuecomment-1006807902


   Thank you so much, @guiyanakuang !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org