You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/05 21:52:14 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #11650: MINOR: Add PAPI Window and Session store tests for IQv2

vvcephei commented on a change in pull request #11650:
URL: https://github.com/apache/kafka/pull/11650#discussion_r779160412



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java
##########
@@ -800,13 +914,13 @@ public void verifyStore() {
                     throw new AssertionError(queryResult.toString());
                 }
                 assertThat(partitionResult.getFailureReason(), is(FailureReason.UNKNOWN_QUERY_TYPE));
-                assertThat(partitionResult.getFailureMessage(), is(
+                assertThat(partitionResult.getFailureMessage(), matchesPattern(
                     "This store"
-                        + " (class org.apache.kafka.streams.state.internals.MeteredTimestampedWindowStore)"
+                        + " \\(class org.apache.kafka.streams.state.internals.Metered.*WindowStore\\)"

Review comment:
       Regardless of whether you supply a bytes store to the DSL, you wind up wrapped in a Timestamped store. Now that we're registering the non-timestamped store directly with the PAPI, we can also get a non-timestamped metered store, hence swapping this for a regex that matches both `MeteredWindowStore` and `MeteredTimestampedWindowStore`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org