You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/11/21 17:30:09 UTC
[GitHub] [calcite] tanclary opened a new pull request, #2978: [Calcite-5385] Add BigQuery as support library for implemented functions
tanclary opened a new pull request, #2978:
URL: https://github.com/apache/calcite/pull/2978
Add BigQuery as a supported library for functions that have already been implemented for other libraries. This ticket overrides Calcite-5384 to include other functions that need BQ added as a supported library.
Note: This is my first Calcite PR so any feedback on the changes, the formatting of the PR, or any other aspect is highly appreciated. Thank you!
List of functions:
MD5()
SHA1()
GREATEST()
LEAST()
COSH()
SINH()
TANH()
FROM_BASE64()
LEFT()
LTRIM()
REPEAT()
REVERSE()
RIGHT()
RTRIM()
SOUNDEX()
TRANSLATE()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on a diff in pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions
Posted by GitBox <gi...@apache.org>.
julianhyde commented on code in PR #2978:
URL: https://github.com/apache/calcite/pull/2978#discussion_r1036312316
##########
gradle.properties:
##########
@@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should not include "-SNAPSHOT" as it is automatically added by build.gradle.kts
# Release version can be generated by using -Prelease or -Prc=<int> arguments
-calcite.version=1.33.0
+calcite.version=1.33.0-tannerclary
Review Comment:
it did slip in. I fixed it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] tjbanghart commented on a diff in pull request #2978: [CALCITE-5385] Add BigQuery as support library for implemented functions
Posted by GitBox <gi...@apache.org>.
tjbanghart commented on code in PR #2978:
URL: https://github.com/apache/calcite/pull/2978#discussion_r1028359636
##########
gradle.properties:
##########
@@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should not include "-SNAPSHOT" as it is automatically added by build.gradle.kts
# Release version can be generated by using -Prelease or -Prc=<int> arguments
-calcite.version=1.33.0
+calcite.version=1.33.0-tannerclary
Review Comment:
Wouldn't want that slipping in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] tanclary commented on a diff in pull request #2978: [CALCITE-5385] Add BigQuery as support library for implemented functions
Posted by GitBox <gi...@apache.org>.
tanclary commented on code in PR #2978:
URL: https://github.com/apache/calcite/pull/2978#discussion_r1028364707
##########
gradle.properties:
##########
@@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should not include "-SNAPSHOT" as it is automatically added by build.gradle.kts
# Release version can be generated by using -Prelease or -Prc=<int> arguments
-calcite.version=1.33.0
+calcite.version=1.33.0-tannerclary
Review Comment:
Whoops, good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde closed pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions
Posted by GitBox <gi...@apache.org>.
julianhyde closed pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions
URL: https://github.com/apache/calcite/pull/2978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org