You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/07/13 23:19:16 UTC

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11103: Improve error message in QueryDispatcher

xiangfu0 commented on code in PR #11103:
URL: https://github.com/apache/pinot/pull/11103#discussion_r1263132905


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -101,6 +101,8 @@ public ResultTable submitAndReduce(long requestId, DispatchableSubPlan dispatcha
     } catch (Exception e) {
       cancel(requestId, dispatchableSubPlan);
       throw new RuntimeException("Error executing query: " + ExplainPlanPlanVisitor.explain(dispatchableSubPlan), e);
+    } catch (Throwable t) {

Review Comment:
   should you just merge Throwable with Exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org