You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by gl...@apache.org on 2002/06/21 23:56:13 UTC

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp BasicDataSourceFactory.java

glenn       2002/06/21 14:56:13

  Modified:    dbcp/src/java/org/apache/commons/dbcp
                        BasicDataSourceFactory.java
  Log:
  Bug fix, boolean properties were always set to false
  
  Revision  Changes    Path
  1.3       +9 -9      jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSourceFactory.java
  
  Index: BasicDataSourceFactory.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSourceFactory.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BasicDataSourceFactory.java	16 May 2002 21:25:37 -0000	1.2
  +++ BasicDataSourceFactory.java	21 Jun 2002 21:56:13 -0000	1.3
  @@ -124,13 +124,13 @@
           ra = ref.get("defaultAutoCommit");
           if (ra != null) {
               dataSource.setDefaultAutoCommit
  -                (Boolean.getBoolean(ra.getContent().toString()));
  +                (Boolean.valueOf(ra.getContent().toString()).booleanValue());
           }
   
           ra = ref.get("defaultReadOnly");
           if (ra != null) {
               dataSource.setDefaultReadOnly
  -                (Boolean.getBoolean(ra.getContent().toString()));
  +                (Boolean.valueOf(ra.getContent().toString()).booleanValue());
           }
   
           ra = ref.get("driverClassName");
  @@ -179,7 +179,7 @@
           ra = ref.get("removeAbandoned");
           if (ra != null) {
               dataSource.setRemoveAbandoned
  -                (Boolean.getBoolean(ra.getContent().toString()));
  +                (Boolean.valueOf(ra.getContent().toString()).booleanValue());
           }
   
           ra = ref.get("removeAbandonedTimeout");
  @@ -189,9 +189,9 @@
           }
   
           ra = ref.get("logAbandoned");
  -        if (ra != null) {     
  +        if (ra != null) {
               dataSource.setLogAbandoned
  -                (Boolean.getBoolean(ra.getContent().toString()));
  +                (Boolean.valueOf(ra.getContent().toString()).booleanValue());
           }
   
           // Return the configured data source instance
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>