[GitHub] [iceberg] kbendick commented on a change in pull request #1539: Add names to parameterized tests and simplify the parameters list

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #1539:
URL: https://github.com/apache/iceberg/pull/1539#discussion_r497979964



##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -130,6 +130,24 @@ public void close() throws CatalogException {
     }
   }
 
+  // Going to save this change for another PR as this PR is already really big.

Review comment:
       Yeah. All of the classes that show up kind of wonky, I'm going to just treat the same in this PR (let them show up as (new String[2]{"hello", "world"}).toString like the JUnit runner wants them to), and then I'll open an issue to follow up on them in a separate PR.
   
   So this PR can be a straight addition of just names to the tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org