[jira] Commented: (HARMONY-3310) [drlvm][doc] interpreter headers should be complemented with code comments

["Nadya Morozova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494208 ] 

Nadya Morozova commented on HARMONY-3310:
-----------------------------------------

Hi,
i've applied the 6file patch, here are a few comments:

interpreter_exports.h: line 308 and comment above it: had a conflict during merge, is it     void (*stack_dump) (VM_thread*); or    void (*stack_dump) (FILE *, VM_thread*); ? 
interpreter_imports.h and interpreter.h have been chagned earlier.

i committed the patch for internal headers at  revision: 536108  
please resolve the remaining issues and we'll close the issue. thanks for the work you're doing.

> [drlvm][doc] interpreter headers should be complemented with code comments
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-3310
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3310
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Nadya Morozova
>         Assigned To: Nadya Morozova
>         Attachments: 3_interpreter_headers.patch, 3_interpreter_headers.patch, 6_interpreter_headers.patch, interp_defs_comments.patch, interpreter_exports_h_comments.patch, interpreter_h_comments.patch, interpreter_imports_h_comments.patch
>
>
> header files located in drlvm\trunk\vm\interpreter\src have very scarse comments. i suggest that we improve those.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.