[jira] [Commented] (MESOS-2936) Create a design document for Quota support in Master

["Yong Qiao Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007932#comment-15007932 ] 

Yong Qiao Wang commented on MESOS-2936:
---------------------------------------

Hey, [~alexr] and [~js84], as we talked as above, role should only can be added by /roles endpoint, and /quota endpoint should not modify roles, so I think we should remove the TODO comment located in src/master/quota_handler.cpp:204L as below. 

{code}
  // TODO(alexr): Once we are able to dynamically add roles, we should stop
  // checking whether the requested role is known to the master, because an
  // operator may set quota for a role that is about to be introduced.
  if (!master->roles.contains(create.get().role())) {
    return BadRequest("Failed to validate set quota request query string: ('" +
                      request.body +"')': Unknown role: '" +
                      create.get().role() + "'");
  }
{code}



> Create a design document for Quota support in Master
> ----------------------------------------------------
>
>                 Key: MESOS-2936
>                 URL: https://issues.apache.org/jira/browse/MESOS-2936
>             Project: Mesos
>          Issue Type: Documentation
>          Components: documentation
>            Reporter: Alexander Rukletsov
>            Assignee: Alexander Rukletsov
>              Labels: mesosphere
>
> Create a design document for the Quota feature support in Mesos Master (excluding allocator) to be shared with the Mesos community.
> Design Doc:
> https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)