You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2011/01/11 21:06:46 UTC

[jira] Created: (DERBY-4967) Handle interrupt received while waiting for database lock

Handle interrupt received while waiting for database lock
---------------------------------------------------------

                 Key: DERBY-4967
                 URL: https://issues.apache.org/jira/browse/DERBY-4967
             Project: Derby
          Issue Type: Improvement
          Components: Store
            Reporter: Dag H. Wanvik
             Fix For: 10.8.0.0


Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980816#action_12980816 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Committed the patch as svn 1058245, resolving.

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment:     (was: derby-4741-locking-1.diff)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980818#action_12980818 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Resolved, post-commit reviews still welcome :)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik reopened DERBY-4967:
----------------------------------


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981862#action_12981862 ] 

Dag H. Wanvik edited comment on DERBY-4967 at 1/14/11 1:37 PM:
---------------------------------------------------------------

Uploading derby-4967-locking-2, which makes the existing test LockInterruptTest
assert that the interrupt flag is set when we see 08000 (CONN_INTERRUPT).

This was not the case before derby-4967-locking-1 was committed.

Note: On Solaris, the test only asserts the flag this if one of the following conditions hold:

- the flag derbyTesting.safeSolarisInterrupts is true. This can be used for force the assert to run
  for Solaris with Java 1.6 and lower. The assert will only succeed then if the Java flag -XX:-UseVMInterruptibleIO is used.
- the test is running on Java 1.7 or higher

If the test is skipped, we do a println to indicate this (iff derby.tests.debug is true).

On other platforms we always do the assert.

BaseTestCase has been extended with two methods to allows tests to determine if they are running with safe Solaris: #isSolaris and #isSafeSolarisInterrupts

Running regressions.



      was (Author: dagw):
    Uploading derby-4967-locking-2, which makes the existing test LockInterruptTest
assert that the interrupt flag is set when we see 08000 (CONN_INTERRUPT).

This was not the case before derby-4967-locking-1 was committed.

Note: On Solaris, the test only asserts the flag this if one of the following conditions hold:

- the flag derbyTesting.safeSolarisInterrupts is true. This can be used for force the tests to run
  for Solaris with Java1.6 and lower. The test will then if the Java flag -XX:-UseVMInterruptibleIO is used.
- the test is running on Java 1.7 or higher

If the test is skipped, we do a println to indicate this (iff derby.tests.debug is true).

On other platforms we always do the assert.

Running regressions.

BaseTestCase has been extended with two methods to allows tests to determine if they are running with safe Solaris: #isSolaris and #isSafeSolarisInterrupts

  
> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-2.diff

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment:     (was: derby-4967-locking-2.diff)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4741-locking-1.stat
                derby-4741-locking-1.diff

Uploading a patch which makes Derby give up waiting for a lock if an interrupt is seen.
Instead it will throw SQLState.CONN_INTERRUPT.



> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4741-locking-1.diff, derby-4741-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982636#action_12982636 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Yes, I agree this would be nicer. I'll run some experiments and see.

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment:     (was: derby-4967-locking-3.diff)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980411#action_12980411 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Passed suites.All.

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982391#action_12982391 ] 

Knut Anders Hatlen commented on DERBY-4967:
-------------------------------------------

> - the flag derbyTesting.safeSolarisInterrupts is true. This can be used for force the assert to run
>   for Solaris with Java 1.6 and lower. The assert will only succeed then if the Java flag -XX:-UseVMInterruptibleIO is used.

Could we detect this dynamically by trying some operation and seeing how it behaves? If that could be done easily, it might be preferable to setting a property to get it tested.

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik resolved DERBY-4967.
----------------------------------

    Resolution: Fixed

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-3.stat
                derby-4967-locking-3.diff

Uploading version three of this patch. BaseTestCase now contains a method "hasInterruptibleIO" which will autodetect if IO is interruptible, which makes the test code easier. Running regressions.



> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-2.stat
                derby-4967-locking-2.diff

Uploading derby-4967-locking-2, which makes the existing test LockInterruptTest
assert that the interrupt flag is set when we see 08000 (CONN_INTERRUPT).

This was not the case before derby-4967-locking-1 was committed.

Note: On Solaris, the test only asserts the flag this if one of the following conditions hold:

- the flag derbyTesting.safeSolarisInterrupts is true. This can be used for force the tests to run
  for Solaris with Java1.6 and lower. The test will then if the Java flag -XX:-UseVMInterruptibleIO is used.
- the test is running on Java 1.7 or higher

If the test is skipped, we do a println to indicate this (iff derby.tests.debug is true).

On other platforms we always do the assert.

Running regressions.

BaseTestCase has been extended with two methods to allows tests to determine if they are running with safe Solaris: #isSolaris and #isSafeSolarisInterrupts


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983738#action_12983738 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Thanks, Knut. Just checked, RAF.close() doesn't give an interrupt as far as I can see,  but it seems safer, I agree, I'll fix that plus the nit, +1 to simplification :)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980306#action_12980306 ] 

Dag H. Wanvik edited comment on DERBY-4967 at 1/12/11 12:23 PM:
----------------------------------------------------------------

Uploading a patch which makes Derby give up waiting for a lock if an interrupt is seen.
Instead it will throw SQLState.CONN_INTERRUPT (the thread's interrupt flag will still be set).



      was (Author: dagw):
    Uploading a patch which makes Derby give up waiting for a lock if an interrupt is seen.
Instead it will throw SQLState.CONN_INTERRUPT.


  
> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik resolved DERBY-4967.
----------------------------------

    Resolution: Fixed

Committed patch revision 4 as svn 1060832. resolving.


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat, derby-4967-locking-4.diff, derby-4967-locking-4.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983464#action_12983464 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

suites.All ran ok.


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Issue & fix info: [Patch Available]

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-4.stat
                derby-4967-locking-4.diff

Uploading version 4 to handle Knut's comments.


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat, derby-4967-locking-4.diff, derby-4967-locking-4.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-3.diff

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment:     (was: derby-4741-locking-1.stat)

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983673#action_12983673 ] 

Knut Anders Hatlen commented on DERBY-4967:
-------------------------------------------

Thanks, Dag. This way to detect the whether interruptible I/O is enabled looks fine to me.

Is RAF.close() interruptible, by the way? I see that the interrupt flag isn't cleared until after close() has been called. Maybe it's safer to postpone the closing until after the interrupt flag has been cleared?

And a tiny nit: If you move "new RandomAccessFile(...)" out of the try clause and up to the declaration, the file can be closed unconditionally in the finally clause (can never be null).

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat, derby-4967-locking-3.diff, derby-4967-locking-3.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981985#action_12981985 ] 

Dag H. Wanvik commented on DERBY-4967:
--------------------------------------

Regressions passed.


> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat, derby-4967-locking-2.diff, derby-4967-locking-2.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4967:
---------------------------------

    Attachment: derby-4967-locking-1.stat
                derby-4967-locking-1.diff

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-4967) Handle interrupt received while waiting for database lock

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik reassigned DERBY-4967:
------------------------------------

    Assignee: Dag H. Wanvik

> Handle interrupt received while waiting for database lock
> ---------------------------------------------------------
>
>                 Key: DERBY-4967
>                 URL: https://issues.apache.org/jira/browse/DERBY-4967
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.8.0.0
>
>         Attachments: derby-4967-locking-1.diff, derby-4967-locking-1.stat
>
>
> Subtask of DERBY-4741: this issue tracks the changes needed to handle interrupt received while a thread is waiting for a database lock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.