You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/26 14:08:30 UTC

[GitHub] [cloudstack] kricud opened a new issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

kricud opened a new issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724


   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and main branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   UI
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on main branch.
   -->
   
   ~~~
   4.15.2
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   Regular domain admin account cannot change nicAdapter “Request Failed (431)” in new UI in OLD it works.
   ![acs_nic](https://user-images.githubusercontent.com/30048481/143592942-5635862e-7976-4aef-88fb-a6e8afb80cd6.png)
   
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   
   <!-- Paste example playbooks or commands between quotes below -->
   ~~~
   Edit nicAdapter settings
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   Regular domain admin account can change nicAdapter
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   Regular domain admin account cannot change nicAdapter
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1019435459


   @sureshanaparti From CMK it works
   
   ![11](https://user-images.githubusercontent.com/30048481/150669997-1c63a869-b140-4a62-b7d3-2afad979c78b.png)
   ![22](https://user-images.githubusercontent.com/30048481/150669998-cf14bf0b-65e4-4ca7-910c-6d2739e50838.png)
   ![33](https://user-images.githubusercontent.com/30048481/150669999-b97fb76c-9a2f-48ec-9014-349a9b9a36b7.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010220625


   @kricud in the video I was first logged in as domain admin only. Please see initial few seconds. Later I logged in as root admin to show ACS version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti closed issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti closed issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1019801913


   Hi @kricud Noticed the read-only detail '_rootDiskController_' is passed in the updateVirtualMachine API call from your tests, due to which API fails. I tried the same in my env, and couldn't reproduce it.
   
   UI filters the read-only details before calling the API, but in your case the read-only detail '_rootDiskController_ exists in the call. Can you clear the browser cache and retry? Any custom UI changes in your env?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti edited a comment on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010137370


   Hi @kricud Is it fresh installation or upgraded one? Can you check if _nicAdapter_ / _rootDiskController_ detail mentioned in the global settings: 'user.vm.denied.details' and 'user.vm.readonly.details'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010099716


   @kricud seems to be working okay in my testing for `nicAdapter` with domain admin on 4.15.2.0
   ![domain-admin](https://user-images.githubusercontent.com/153340/148975922-2a4b1270-9934-4f46-8ac0-4e0ae188e69f.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud edited a comment on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud edited a comment on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010823766


   @shwstppr Step by step how to reproduce it.
   1. Install Windows Server from ISO
   2. Hypervisor is Vmware
   3. Install VMware Tools on VM
   4. Reboot
   5. By default in VMware nic adapter is E1000
   6. Shutdown VM
   7. Try change nic adapter to VMxnet3 and get error in new UI.
   8. Try change nic adapter to VMxnet3 in old UI and its working.
   ![1](https://user-images.githubusercontent.com/30048481/149099133-5f9455fd-5065-4c1d-9d03-e2bcf367273f.png)
   ![2](https://user-images.githubusercontent.com/30048481/149099143-32b34af6-c6e7-40e6-aada-930a2587edd5.png)
   ![3](https://user-images.githubusercontent.com/30048481/149099150-bc9c9153-f271-4d39-a83c-4c8648a4bc7d.png)
   ![4](https://user-images.githubusercontent.com/30048481/149099165-7ce9743c-b81b-4a19-a759-6eb4bc586065.png)
   ![55](https://user-images.githubusercontent.com/30048481/149099388-bc958f8f-48cc-4b17-819f-cdb40345a8be.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010216512


   @sureshanaparti In global settings I have only user.vm.readonly.ui.details with value dataDiskController, rootDiskController. Don’t have user.vm.denied.details.
   
   @shwstppr User admin has Role “Root Admin” Role Type “Admin” with these permissions it works.
   Its not working if you have Account with Role “Domain Admin” Role Type “Domain Admin” and user created under this account cannot change nicAdapter.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1025657350


   Fixed in #5887 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud edited a comment on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud edited a comment on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1019853627


   @sureshanaparti Cache reset is not helping
   
   ![11](https://user-images.githubusercontent.com/30048481/150750425-af270e6b-8656-4acb-9fec-8b9ba56926ad.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1019859105


   @kricud I've created a PR (https://github.com/apache/cloudstack/pull/5887) to fix the issue. It seems UI was not filtering readonly details


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1009986491


   @shwstppr ACS 4.15.2
   ![E1000ToVMxnet3_error](https://user-images.githubusercontent.com/30048481/148955298-d3fd03a3-cbe3-4afc-8292-56de440ebc0b.JPG)
   From top:
   First legacy UI
   Second new UI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010823766


   @shwstppr Step by step how to reproduce it.
   1. Install Windows Server from ISO
   2. Hypervisor is Vmware
   3. Install VMware Tools on VM
   4. Reboot
   5. By default in VMware nic adapter is E1000
   6. Shutdown VM
   7. Try change nic adapter to VMxnet3, get and get error in new UI
   8. Try change nic adapter to VMxnet3 in old UI and its working.
   ![1](https://user-images.githubusercontent.com/30048481/149099133-5f9455fd-5065-4c1d-9d03-e2bcf367273f.png)
   ![2](https://user-images.githubusercontent.com/30048481/149099143-32b34af6-c6e7-40e6-aada-930a2587edd5.png)
   ![3](https://user-images.githubusercontent.com/30048481/149099150-bc9c9153-f271-4d39-a83c-4c8648a4bc7d.png)
   ![4](https://user-images.githubusercontent.com/30048481/149099165-7ce9743c-b81b-4a19-a759-6eb4bc586065.png)
   ![55](https://user-images.githubusercontent.com/30048481/149099388-bc958f8f-48cc-4b17-819f-cdb40345a8be.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] kricud commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
kricud commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1019853627


   @sureshanaparti Cache reset is not helping
   ![11](https://user-images.githubusercontent.com/30048481/150750425-af270e6b-8656-4acb-9fec-8b9ba56926ad.png)
   g


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1017203586


   Hi @kricud Can you try with API/cmk update virtualmachine. Also, please share the API calls (from browser developer tools) from old and new UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1010137370


   @kricud @shwstppr Can you check the details set in the global settings: 'user.vm.denied.details' and 'user.vm.readonly.details'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on issue #5724: Regular domain admin account cannot change nicAdapter “Request Failed (431)”

Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #5724:
URL: https://github.com/apache/cloudstack/issues/5724#issuecomment-1009670127


   @kricud are you sure about that this worked in the old UI. The error seen here comes from backend and I checked in 4.15.1.0 as well and the code is same - it doesn't allow non-root admins to update these settings,
   https://github.com/apache/cloudstack/blob/4.15.1.0/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L2574-L2583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org