You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/21 15:59:05 UTC
[GitHub] [iceberg] RussellSpitzer opened a new pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
RussellSpitzer opened a new pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223
This is an easy PR, no Prod code changes, just improves test coverage :)
Previously none of the tests in TestRemoveSnapshots used the code path for
valid snapshots which contained references to manifests which were created
in a snapshot that had previously expired. Although there are no bugs in that
logic, we add two tests which check this pathway to protect against future
breakage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223#discussion_r458249862
##########
File path: core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java
##########
@@ -356,6 +356,74 @@ public void testRetainZeroSnapshots() {
() -> table.expireSnapshots().retainLast(0).commit());
}
+ @Test
+ public void testScanExpireddManifestInValidSnapshotAppend() {
Review comment:
nit: `Expiredd`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223#issuecomment-661948242
cc @aokolnychyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223#discussion_r458253047
##########
File path: core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java
##########
@@ -356,6 +356,74 @@ public void testRetainZeroSnapshots() {
() -> table.expireSnapshots().retainLast(0).commit());
}
+ @Test
+ public void testScanExpireddManifestInValidSnapshotAppend() {
Review comment:
I'm gonna try size 18 font now .... :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223#issuecomment-662054831
Thanks, @RussellSpitzer!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #1223: Adds Tests for Untested RemoveSnapshot Pathway
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #1223:
URL: https://github.com/apache/iceberg/pull/1223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org