You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/12/12 01:06:46 UTC
[kudu-CR] thirdparty: fix bison compilation in macOS High Sierra
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8815
Change subject: thirdparty: fix bison compilation in macOS High Sierra
......................................................................
thirdparty: fix bison compilation in macOS High Sierra
Apparently bison needs a patch to compile in macOS High Sierra.
See: https://github.com/spack/spack/issues/5521
This changeset just adds the patch from that issue and applies
it to bison source tree.
Change-Id: I25e384c5715951488f2fc10b64da764e48e1fec0
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/bison-fix-high-sierra-compilation-issue.patch
2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8815/1
--
To view, visit http://gerrit.cloudera.org:8080/8815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25e384c5715951488f2fc10b64da764e48e1fec0
Gerrit-Change-Number: 8815
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
[kudu-CR] thirdparty: fix bison compilation in macOS High Sierra
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8815 )
Change subject: thirdparty: fix bison compilation in macOS High Sierra
......................................................................
thirdparty: fix bison compilation in macOS High Sierra
Apparently bison needs a patch to compile in macOS High Sierra.
See: https://github.com/spack/spack/issues/5521
This changeset just adds the patch from that issue and applies
it to bison source tree.
Change-Id: I25e384c5715951488f2fc10b64da764e48e1fec0
Reviewed-on: http://gerrit.cloudera.org:8080/8815
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/bison-fix-high-sierra-compilation-issue.patch
2 files changed, 19 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25e384c5715951488f2fc10b64da764e48e1fec0
Gerrit-Change-Number: 8815
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] thirdparty: fix bison compilation in macOS High Sierra
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8815 )
Change subject: thirdparty: fix bison compilation in macOS High Sierra
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e384c5715951488f2fc10b64da764e48e1fec0
Gerrit-Change-Number: 8815
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 12 Dec 2017 01:16:24 +0000
Gerrit-HasComments: No