[GitHub] [pinot] walterddr commented on a diff in pull request #10726: [bugfix] Pinot config env substitution

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10726:
URL: https://github.com/apache/pinot/pull/10726#discussion_r1199242904


##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -356,15 +354,7 @@ public long getProperty(String name, long defaultValue) {
    * @return the property String value. Fallback to default value if missing.
    */
   public String getProperty(String name, String defaultValue) {
-    Object rawProperty = getRawProperty(name, defaultValue);
-    if (rawProperty instanceof List) {
-      return StringUtils.join(((ArrayList) rawProperty).toArray(), ',');
-    } else {
-      if (rawProperty == null) {
-        return null;
-      }
-      return rawProperty.toString();
-    }
+    return _configuration.getString(relaxPropertyName(name), defaultValue);

Review Comment:
   we should probably keep the original logic for this one? (maybe check null first) 
   i don't think this change is needed as long as the previous bug fix is in. please double check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org