[GitHub] [incubator-echarts] alex2wong commented on issue #11367: Fix 11236 integrate stack/tile button into one toggle button in toolbox

[GitBox <gi...@apache.org>]

alex2wong commented on issue #11367: Fix 11236 integrate stack/tile button into one toggle button in toolbox
URL: https://github.com/apache/incubator-echarts/pull/11367#issuecomment-559297044
 
 
   > I tested and ran locally. The text changed and seems to be working as expected. But the icon didn't change. Is this expected? @alex2wong
   
   @Ovilia Yes, as the function specs mentioned.. Icon itself did not switch between stack/tiled, only the title and emphasis status changed. Of course, here's another design, switch between stack/tiled icon instead of emphasis it.  How do you think about it ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org