[GitHub] [cassandra] jakubzytka commented on a diff in pull request #2336: CASSANDRA-18506: Upgrade tests cleanup

["jakubzytka (via GitHub)" <gi...@apache.org>]

jakubzytka commented on code in PR #2336:
URL: https://github.com/apache/cassandra/pull/2336#discussion_r1193926933


##########
test/distributed/org/apache/cassandra/distributed/upgrade/CompactionHistorySystemTableUpgradeTest.java:
##########
@@ -19,44 +19,26 @@
 package org.apache.cassandra.distributed.upgrade;
 
 import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.Lists;
 
-import com.vdurmont.semver4j.Semver;
 import org.apache.cassandra.db.compaction.OperationType;
 import org.apache.cassandra.distributed.api.ConsistencyLevel;
 import org.apache.cassandra.tools.ToolRunner;
 
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameter;
-import org.junit.runners.Parameterized.Parameters;
-
-import java.util.ArrayList;
 
 import static org.apache.cassandra.db.compaction.CompactionHistoryTabularData.COMPACTION_TYPE_PROPERTY;
 import static org.apache.cassandra.tools.ToolRunner.invokeNodetoolJvmDtest;
 import static org.apache.cassandra.tools.nodetool.CompactionHistoryTest.assertCompactionHistoryOutPut;
 
-@RunWith(Parameterized.class)
 public class CompactionHistorySystemTableUpgradeTest extends UpgradeTestBase
 {
-    @Parameter
-    public Semver version;
-
-    @Parameters()
-    public static ArrayList<Semver> versions()
-    {
-        return Lists.newArrayList(v30, v3X, v40, v41);
-    }
-
     @Test
     public void compactionHistorySystemTableTest() throws Throwable
     {
         new TestCase()
         .nodes(1)
         .nodesToUpgrade(1)
-        .upgradesToCurrentFrom(version)
+        .minimalApplicableVersion(v30)

Review Comment:
   prior to the change the same upgrades would have been run (e.g. for parameter v30 and v3x the same set of v4->v5 and v4.1 -> v5 upgrades would have been run)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org