You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 15:05:33 UTC

[GitHub] [arrow] nealrichardson commented on pull request #8536: ARROW-10399: [R] Fix performance regression from cpp11::r_string

nealrichardson commented on pull request #8536:
URL: https://github.com/apache/arrow/pull/8536#issuecomment-717308032


   > `cpp11::r_string(const std::string&)` does not take advantage of knowing the length of the string (so the terminating null must be searched for),
   
   Side note: it's not always safe to assume nuls are terminating, and R and Rcpp don't assume that. cf. #8365


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org