You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/07 05:06:42 UTC
[GitHub] [airflow] kaxil opened a new pull request #7092: [AIRFLOW-6347]
BugFix: Can't get task logs when serialization is enabled
kaxil opened a new pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092
Quoting from Jira:
**Problem**:
When I set next config options in `airflow.cfg`:
```ini
[core]
store_serialized_dags = True
min_serialized_dag_update_interval = 3
```
View with task logs shows infinity Js spinner, while in webserver log I see next error:
```
[2019-12-25 14:48:57,640] {{app.py:1891}} ERROR - Exception on /get_logs_with_metadata [GET]
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 1935, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/www_rbac/decorators.py", line 121, in wrapper
return f(self, *args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/flask_appbuilder/security/decorators.py", line 101, in wraps
return f(self, *args, **kwargs)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/www_rbac/decorators.py", line 56, in wrapper
return f(*args, **kwargs)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
return func(*args, **kwargs)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 637, in get_logs_with_metadata
logs, metadata = _get_logs_with_metadata(try_number, metadata)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 628, in _get_logs_with_metadata
logs, metadatas = handler.read(ti, try_number, metadata=metadata)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line 169, in read
log, metadata = self._read(task_instance, try_number_element, metadata)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line 98, in _read
log_relative_path = self._render_filename(ti, try_number)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line 75, in _render_filename
jinja_context = ti.get_template_context()
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
return func(*args, **kwargs)
File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/models/taskinstance.py", line 1149, in get_template_context
if 'tables' in task.params:
TypeError: argument of type 'NoneType' is not iterable
```
**Solution:**
This is because we use `self.params = params or {}` and where default value of `params` is `None` in DAG and Operators and Dag S10n ignore all the None field.
While de-serializing `params` was being set to None because of the following line:
```python
keys_to_set_none = dag.get_serialized_fields() - encoded_dag.keys() - cls._CONSTRUCTOR_PARAMS.keys()
for k in keys_to_set_none:
setattr(dag, k, None)
```
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7092: [AIRFLOW-6347]
BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/748e3c3519b6cfeb82929efa6cc2d11ca0154b49?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 85.07% 84.87% -0.21%
==========================================
Files 680 680
Lines 38810 38824 +14
==========================================
- Hits 33019 32951 -68
- Misses 5791 5873 +82
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [748e3c3...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/748e3c3519b6cfeb82929efa6cc2d11ca0154b49?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 85.07% 84.87% -0.21%
==========================================
Files 680 680
Lines 38810 38824 +14
==========================================
- Hits 33019 32951 -68
- Misses 5791 5873 +82
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [748e3c3...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363844214
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -265,12 +266,9 @@ class SerializedBaseOperator(BaseOperator, BaseSerialization):
Class specific attributes used by UI are move to object attributes.
"""
- _decorated_fields = {'executor_config', }
+ _decorated_fields = {'executor_config', 'params'}
Review comment:
Removed this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7092: [AIRFLOW-6347] BugFix:
Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571558130
Maybe we should create a new context for Jinja used to render log filename templates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363865931
##########
File path: airflow/utils/decorators.py
##########
@@ -64,7 +64,7 @@ def wrapper(*args, **kwargs):
dag_args = copy(dag.default_args) or {}
dag_params = copy(dag.params) or {}
- params = kwargs.get('params', {})
+ params = kwargs.get('params', {}) or {}
Review comment:
This is correct, but looks odd. This is covered by a test right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363752005
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -265,12 +266,9 @@ class SerializedBaseOperator(BaseOperator, BaseSerialization):
Class specific attributes used by UI are move to object attributes.
"""
- _decorated_fields = {'executor_config', }
+ _decorated_fields = {'executor_config', 'params'}
Review comment:
I think adding this change now changes the format of the serialization we store, and since the previous format was in 1.10.7 I thin kthis means we now need to think about adding a v2 of the format and how we deal with upgrade etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363879214
##########
File path: airflow/utils/decorators.py
##########
@@ -64,7 +64,7 @@ def wrapper(*args, **kwargs):
dag_args = copy(dag.default_args) or {}
dag_params = copy(dag.params) or {}
- params = kwargs.get('params', {})
+ params = kwargs.get('params', {}) or {}
Review comment:
https://github.com/apache/airflow/pull/7092/files#diff-beca6224080086e983c4dd9649fca3feR416 would fail if someone removes `or {}` so yes it is covered.
I can add a separate test in `test/utils/test_decorator.py` if you think that would be good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e6f2e19](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363866560
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -253,7 +253,8 @@ def _value_is_hardcoded_default(cls, attrname: str, value: Any) -> bool:
default. (This is because ``"default" is "default"`` will be False as
they are different strings with the same characters.)
"""
- if attrname in cls._CONSTRUCTOR_PARAMS and cls._CONSTRUCTOR_PARAMS[attrname].default is value:
+ if attrname in cls._CONSTRUCTOR_PARAMS and \
+ (cls._CONSTRUCTOR_PARAMS[attrname].default is value or (value in [{}, []])):
Review comment:
If something has a default of None and a user explicitly passes in None, does this change now mean we store it sa `null` in the JSON?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7092: [AIRFLOW-6347] BugFix:
Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571711433
> Maybe we should create a new context for Jinja used to render log filename templates?
We've had problems in the past (around 1.8.2->1.9 time) where we changed the logging config, and old logs were no longer visible in the UI unless someone went and renamed the old files/S3 objects etc. I think the thing to do instead (and this might be a 2.0 thing) is to:
1. Store the rendered log file name in the TI table
2. Have a different row for each TI, so that we have a sensible place to store this info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e6f2e19](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.64%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.29% -0.65%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32727 -251
- Misses 5848 6097 +249
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...e2f4e24](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363867286
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -253,7 +253,8 @@ def _value_is_hardcoded_default(cls, attrname: str, value: Any) -> bool:
default. (This is because ``"default" is "default"`` will be False as
they are different strings with the same characters.)
"""
- if attrname in cls._CONSTRUCTOR_PARAMS and cls._CONSTRUCTOR_PARAMS[attrname].default is value:
+ if attrname in cls._CONSTRUCTOR_PARAMS and \
+ (cls._CONSTRUCTOR_PARAMS[attrname].default is value or (value in [{}, []])):
Review comment:
No it is excluded because of the following function:
https://github.com/apache/airflow/blob/e6f2e19912a1c588c79bb8ac137d09d6789d8126/airflow/serialization/serialized_objects.py#L107-L114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7092: [AIRFLOW-6347] BugFix:
Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363884443
##########
File path: airflow/utils/decorators.py
##########
@@ -64,7 +64,7 @@ def wrapper(*args, **kwargs):
dag_args = copy(dag.default_args) or {}
dag_params = copy(dag.params) or {}
- params = kwargs.get('params', {})
+ params = kwargs.get('params', {}) or {}
Review comment:
Think we're good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#issuecomment-571674770
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=h1) Report
> Merging [#7092](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7092 +/- ##
==========================================
- Coverage 84.93% 84.87% -0.07%
==========================================
Files 680 680
Lines 38826 38824 -2
==========================================
- Hits 32978 32951 -27
- Misses 5848 5873 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.72% <100%> (-0.41%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/airflow/pull/7092/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=footer). Last update [2b37472...723d073](https://codecov.io/gh/apache/airflow/pull/7092?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7092:
[AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363753439
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -265,12 +266,9 @@ class SerializedBaseOperator(BaseOperator, BaseSerialization):
Class specific attributes used by UI are move to object attributes.
"""
- _decorated_fields = {'executor_config', }
+ _decorated_fields = {'executor_config', 'params'}
Review comment:
Yup, agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services