You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/05 06:29:28 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
HyukjinKwon opened a new pull request #34181:
URL: https://github.com/apache/spark/pull/34181
### What changes were proposed in this pull request?
This PR proposes to refactor typing logic for multi-index support that was mostly introduced in https://github.com/apache/spark/pull/34176
At a high level, the below functions were introduced
```bash
_extract_types # renamed from `extract_types`
```
```
_is_named_params
_address_named_type_hoders
_to_tuple_of_params
_convert_tuples_to_zip
_address_unnamed_type_holders
```
In this PR, they become as below with simplification:
```bash
_to_type_holders # renamed from `_extract_types`
```
```
_new_type_holders # merged from _is_named_params, etc.
```
### Why are the changes needed?
To make the codes easier to read.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Existing tests should cover them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34181:
URL: https://github.com/apache/spark/pull/34181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934299705
**[Test build #143849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143849/testReport)** for PR 34181 at commit [`53940c9`](https://github.com/apache/spark/commit/53940c9350bfc3ceb9a5c0b381dfe9350fb0bbc4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934180242
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934330282
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143849/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934194433
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934149542
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143837/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934299705
**[Test build #143849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143849/testReport)** for PR 34181 at commit [`53940c9`](https://github.com/apache/spark/commit/53940c9350bfc3ceb9a5c0b381dfe9350fb0bbc4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934153369
cc @ueshin @itholic @dchvn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934194433
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934113858
**[Test build #143837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143837/testReport)** for PR 34181 at commit [`2cd268b`](https://github.com/apache/spark/commit/2cd268b84e2f850a7c4ea180f4d2b84d0a63354a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934337188
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48362/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34181:
URL: https://github.com/apache/spark/pull/34181#discussion_r722120859
##########
File path: python/pyspark/pandas/typedef/typehints.py
##########
@@ -726,131 +729,108 @@ def create_tuple_for_frame_type(params: Any) -> object:
... # doctest: +ELLIPSIS
typing.Tuple[...IndexNameType, ...NameType]
"""
- return Tuple[_extract_types(params)]
+ return Tuple[_to_type_holders(params)]
-def _extract_types(params: Any) -> Tuple:
- origin = params
+def _to_type_holders(params: Any) -> Tuple:
+ from pyspark.pandas.typedef import NameTypeHolder, IndexNameTypeHolder
- params = _to_tuple_of_params(params)
+ is_with_index = (
+ isinstance(params, tuple)
+ and len(params) == 2
+ and isinstance(params[1], (zip, list, pd.Series))
+ )
- if _is_named_params(params):
- # Example:
- # DataFrame["id": int, "A": int]
- new_params = _address_named_type_hoders(params, is_index=False)
- return tuple(new_params)
- elif len(params) == 2 and isinstance(params[1], (zip, list, pd.Series)):
- # Example:
- # DataFrame[int, [int, int]]
- # DataFrame[pdf.index.dtype, pdf.dtypes]
- # DataFrame[("index", int), [("id", int), ("A", int)]]
- # DataFrame[(pdf.index.name, pdf.index.dtype), zip(pdf.columns, pdf.dtypes)]
- #
- # DataFrame[[int, int], [int, int]]
- # DataFrame[pdf.index.dtypes, pdf.dtypes]
- # DataFrame[[("index", int), ("index-2", int)], [("id", int), ("A", int)]]
- # DataFrame[zip(pdf.index.names, pdf.index.dtypes), zip(pdf.columns, pdf.dtypes)]
+ if is_with_index:
+ # With index
+ # DataFrame[index_type, [type, ...]]
+ # DataFrame[dtype instance, dtypes instance]
+ # DataFrame[[index_type, ...], [type, ...]]
+ # DataFrame[dtypes instance, dtypes instance]
+ # DataFrame[(index_name, index_type), [(name, type), ...]]
+ # DataFrame[(index_name, index_type), zip(names, types)]
+ # DataFrame[[(index_name, index_type), ...], [(name, type), ...]]
+ # DataFrame[zip(index_names, index_types), zip(names, types)]
+ def is_list_of_pairs(p: Any) -> bool:
+ return (
+ isinstance(p, list) and len(p) >= 1 and isinstance(p[0], tuple) and len(p[0]) == 2
+ )
Review comment:
Thanks, yeah let's do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934374091
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48362/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934129944
**[Test build #143837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143837/testReport)** for PR 34181 at commit [`2cd268b`](https://github.com/apache/spark/commit/2cd268b84e2f850a7c4ea180f4d2b84d0a63354a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` new_class = type(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934113858
**[Test build #143837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143837/testReport)** for PR 34181 at commit [`2cd268b`](https://github.com/apache/spark/commit/2cd268b84e2f850a7c4ea180f4d2b84d0a63354a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934320350
**[Test build #143849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143849/testReport)** for PR 34181 at commit [`53940c9`](https://github.com/apache/spark/commit/53940c9350bfc3ceb9a5c0b381dfe9350fb0bbc4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on a change in pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34181:
URL: https://github.com/apache/spark/pull/34181#discussion_r722083275
##########
File path: python/pyspark/pandas/typedef/typehints.py
##########
@@ -726,131 +729,108 @@ def create_tuple_for_frame_type(params: Any) -> object:
... # doctest: +ELLIPSIS
typing.Tuple[...IndexNameType, ...NameType]
"""
- return Tuple[_extract_types(params)]
+ return Tuple[_to_type_holders(params)]
-def _extract_types(params: Any) -> Tuple:
- origin = params
+def _to_type_holders(params: Any) -> Tuple:
+ from pyspark.pandas.typedef import NameTypeHolder, IndexNameTypeHolder
- params = _to_tuple_of_params(params)
+ is_with_index = (
+ isinstance(params, tuple)
+ and len(params) == 2
+ and isinstance(params[1], (zip, list, pd.Series))
+ )
- if _is_named_params(params):
- # Example:
- # DataFrame["id": int, "A": int]
- new_params = _address_named_type_hoders(params, is_index=False)
- return tuple(new_params)
- elif len(params) == 2 and isinstance(params[1], (zip, list, pd.Series)):
- # Example:
- # DataFrame[int, [int, int]]
- # DataFrame[pdf.index.dtype, pdf.dtypes]
- # DataFrame[("index", int), [("id", int), ("A", int)]]
- # DataFrame[(pdf.index.name, pdf.index.dtype), zip(pdf.columns, pdf.dtypes)]
- #
- # DataFrame[[int, int], [int, int]]
- # DataFrame[pdf.index.dtypes, pdf.dtypes]
- # DataFrame[[("index", int), ("index-2", int)], [("id", int), ("A", int)]]
- # DataFrame[zip(pdf.index.names, pdf.index.dtypes), zip(pdf.columns, pdf.dtypes)]
+ if is_with_index:
+ # With index
+ # DataFrame[index_type, [type, ...]]
+ # DataFrame[dtype instance, dtypes instance]
+ # DataFrame[[index_type, ...], [type, ...]]
+ # DataFrame[dtypes instance, dtypes instance]
+ # DataFrame[(index_name, index_type), [(name, type), ...]]
+ # DataFrame[(index_name, index_type), zip(names, types)]
+ # DataFrame[[(index_name, index_type), ...], [(name, type), ...]]
+ # DataFrame[zip(index_names, index_types), zip(names, types)]
+ def is_list_of_pairs(p: Any) -> bool:
+ return (
+ isinstance(p, list) and len(p) >= 1 and isinstance(p[0], tuple) and len(p[0]) == 2
+ )
Review comment:
Should we check all elements?
``` python
return (
isinstance(p, list)
and (len(p) >= 1)
and all(isinstance(param, tuple) and (len(param) == 2) for param in p)
)
```
for these cases:
```
>>> ps.DataFrame[int, [("index", int), ["index-2", int]]]
typing.Tuple[pyspark.pandas.typedef.typehints.IndexNameType, pyspark.pandas.typedef.typehints.NameType, pyspark.pandas.typedef.typehints.NameType]
>>> ps.DataFrame[int, [("index", int), ("index-2", int, None)]]
typing.Tuple[pyspark.pandas.typedef.typehints.IndexNameType, pyspark.pandas.typedef.typehints.NameType, pyspark.pandas.typedef.typehints.NameType]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934139317
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934149542
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143837/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934330282
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143849/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934369179
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48362/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-935085240
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34181: [SPARK-36711][PYTHON][FOLLOW-UP] Refactor typing logic for multi-index support
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34181:
URL: https://github.com/apache/spark/pull/34181#issuecomment-934374091
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48362/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org