You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by mm...@apache.org on 2007/12/26 04:05:54 UTC
svn commit: r606834 -
/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
Author: mmao
Date: Tue Dec 25 19:05:53 2007
New Revision: 606834
URL: http://svn.apache.org/viewvc?rev=606834&view=rev
Log:
* Fix the checks
Modified:
incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
Modified: incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java?rev=606834&r1=606833&r2=606834&view=diff
==============================================================================
--- incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java (original)
+++ incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java Tue Dec 25 19:05:53 2007
@@ -48,8 +48,8 @@
private void validate() {
for (Handler handler : this.getHandlerChain()) {
if (!(handler instanceof LogicalHandler)) {
- throw new WebServiceException("Adding an incompatible handler in javax.xml.ws.http.HTTPBinding: "
- + handler.getClass());
+ throw new WebServiceException("Adding an incompatible handler in HTTPBinding: "
+ + handler.getClass());
}
}
}
Re: svn commit: r606834 -
/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
Posted by Glen Mazza <gl...@verizon.net>.
I see. Thanks.
Glen
Am Mittwoch, den 26.12.2007, 11:25 +0800 schrieb James Mao:
> Glen,
>
> It's defined in the JAXWS spec, in section 11.1.1.1
> > Conformance (Incompatible handlers): Implementations MUST throw a
> WebServiceException when
> > attempting to configure an incompatible handler using
> Binding.setHandlerChain
>
> That said, in case of HttpBinding, if you add SoapHandler or other
> protocol handlers, it must throw the WebServiceException
>
> James
>
>
> > James, pardon me but I don't understand the code here very well.
> >
> > Your latest patches are limiting JAX-WS handlers to be just
> > LogicalHandlers (and not SOAPHandlers). Question: where are you doing
> > this limitation and under what circumstances is this limitation in
> > place--for clients? for web service implementations? Just for
> > programmatic configuration?
> >
> > Thanks,
> > Glen
> >
> > Am Mittwoch, den 26.12.2007, 03:05 +0000 schrieb mmao@apache.org:
> >
> >> Author: mmao
> >> Date: Tue Dec 25 19:05:53 2007
> >> New Revision: 606834
> >>
> >> URL: http://svn.apache.org/viewvc?rev=606834&view=rev
> >> Log:
> >> * Fix the checks
> >>
> >>
> >> Modified:
> >> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
> >>
> >> Modified: incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
> >> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java?rev=606834&r1=606833&r2=606834&view=diff
> >> ==============================================================================
> >> --- incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java (original)
> >> +++ incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java Tue Dec 25 19:05:53 2007
> >> @@ -48,8 +48,8 @@
> >> private void validate() {
> >> for (Handler handler : this.getHandlerChain()) {
> >> if (!(handler instanceof LogicalHandler)) {
> >> - throw new WebServiceException("Adding an incompatible handler in javax.xml.ws.http.HTTPBinding: "
> >> - + handler.getClass());
> >> + throw new WebServiceException("Adding an incompatible handler in HTTPBinding: "
> >> + + handler.getClass());
> >> }
> >> }
> >> }
> >>
> >>
> >>
> >
> >
Re: svn commit: r606834 - /incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
Posted by James Mao <ja...@iona.com>.
Glen,
It's defined in the JAXWS spec, in section 11.1.1.1
> Conformance (Incompatible handlers): Implementations MUST throw a
WebServiceException when
> attempting to configure an incompatible handler using
Binding.setHandlerChain
That said, in case of HttpBinding, if you add SoapHandler or other
protocol handlers, it must throw the WebServiceException
James
> James, pardon me but I don't understand the code here very well.
>
> Your latest patches are limiting JAX-WS handlers to be just
> LogicalHandlers (and not SOAPHandlers). Question: where are you doing
> this limitation and under what circumstances is this limitation in
> place--for clients? for web service implementations? Just for
> programmatic configuration?
>
> Thanks,
> Glen
>
> Am Mittwoch, den 26.12.2007, 03:05 +0000 schrieb mmao@apache.org:
>
>> Author: mmao
>> Date: Tue Dec 25 19:05:53 2007
>> New Revision: 606834
>>
>> URL: http://svn.apache.org/viewvc?rev=606834&view=rev
>> Log:
>> * Fix the checks
>>
>>
>> Modified:
>> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
>>
>> Modified: incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
>> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java?rev=606834&r1=606833&r2=606834&view=diff
>> ==============================================================================
>> --- incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java (original)
>> +++ incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java Tue Dec 25 19:05:53 2007
>> @@ -48,8 +48,8 @@
>> private void validate() {
>> for (Handler handler : this.getHandlerChain()) {
>> if (!(handler instanceof LogicalHandler)) {
>> - throw new WebServiceException("Adding an incompatible handler in javax.xml.ws.http.HTTPBinding: "
>> - + handler.getClass());
>> + throw new WebServiceException("Adding an incompatible handler in HTTPBinding: "
>> + + handler.getClass());
>> }
>> }
>> }
>>
>>
>>
>
>
Re: svn commit: r606834 -
/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
Posted by Glen Mazza <gl...@verizon.net>.
James, pardon me but I don't understand the code here very well.
Your latest patches are limiting JAX-WS handlers to be just
LogicalHandlers (and not SOAPHandlers). Question: where are you doing
this limitation and under what circumstances is this limitation in
place--for clients? for web service implementations? Just for
programmatic configuration?
Thanks,
Glen
Am Mittwoch, den 26.12.2007, 03:05 +0000 schrieb mmao@apache.org:
> Author: mmao
> Date: Tue Dec 25 19:05:53 2007
> New Revision: 606834
>
> URL: http://svn.apache.org/viewvc?rev=606834&view=rev
> Log:
> * Fix the checks
>
>
> Modified:
> incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
>
> Modified: incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java?rev=606834&r1=606833&r2=606834&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java (original)
> +++ incubator/cxf/trunk/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/binding/http/HTTPBindingImpl.java Tue Dec 25 19:05:53 2007
> @@ -48,8 +48,8 @@
> private void validate() {
> for (Handler handler : this.getHandlerChain()) {
> if (!(handler instanceof LogicalHandler)) {
> - throw new WebServiceException("Adding an incompatible handler in javax.xml.ws.http.HTTPBinding: "
> - + handler.getClass());
> + throw new WebServiceException("Adding an incompatible handler in HTTPBinding: "
> + + handler.getClass());
> }
> }
> }
>
>