You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/10 13:24:58 UTC
Review Request 58296: Create skeleton for Ambari Infra Manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58296/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-20720
https://issues.apache.org/jira/browse/AMBARI-20720
Repository: ambari
Description
-------
add webapp infra-manager skeleton: add dependencies and basic configurations. (as its just skeleton, i added a lot of TODOs)
Diffs
-----
ambari-infra/ambari-infra-manager/README.md PRE-CREATION
ambari-infra/ambari-infra-manager/pom.xml PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfrManagerConstants.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerApiDocConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/log4j.xml PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/swagger/swagger.html PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/webapp/index.html PRE-CREATION
ambari-infra/pom.xml a6a6961
Diff: https://reviews.apache.org/r/58296/diff/1/
Testing
-------
done.
with 'mvn clean package exec:java' you can start the web server
Thanks,
Oliver Szabo
Re: Review Request 58296: Create skeleton for Ambari Infra Manager
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58296/#review172943
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 10, 2017, 1:49 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58296/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 1:49 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20720
> https://issues.apache.org/jira/browse/AMBARI-20720
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add webapp infra-manager skeleton: add dependencies and basic configurations. (as its just skeleton, i added a lot of TODOs)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-manager/README.md PRE-CREATION
> ambari-infra/ambari-infra-manager/pom.xml PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerApiDocConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/log4j.xml PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/swagger/swagger.html PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/webapp/index.html PRE-CREATION
> ambari-infra/pom.xml a6a6961
>
>
> Diff: https://reviews.apache.org/r/58296/diff/2/
>
>
> Testing
> -------
>
> done.
> with 'mvn clean package exec:java' you can start the web server
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58296: Create skeleton for Ambari Infra Manager
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58296/
-----------------------------------------------------------
(Updated April 10, 2017, 1:49 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
fixed class name
Bugs: AMBARI-20720
https://issues.apache.org/jira/browse/AMBARI-20720
Repository: ambari
Description
-------
add webapp infra-manager skeleton: add dependencies and basic configurations. (as its just skeleton, i added a lot of TODOs)
Diffs (updated)
-----
ambari-infra/ambari-infra-manager/README.md PRE-CREATION
ambari-infra/ambari-infra-manager/pom.xml PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerApiDocConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerConfig.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/log4j.xml PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/swagger/swagger.html PRE-CREATION
ambari-infra/ambari-infra-manager/src/main/resources/webapp/index.html PRE-CREATION
ambari-infra/pom.xml a6a6961
Diff: https://reviews.apache.org/r/58296/diff/2/
Changes: https://reviews.apache.org/r/58296/diff/1-2/
Testing
-------
done.
with 'mvn clean package exec:java' you can start the web server
Thanks,
Oliver Szabo
Re: Review Request 58296: Create skeleton for Ambari Infra Manager
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58296/#review171439
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfrManagerConstants.java
Lines 21 (patched)
<https://reviews.apache.org/r/58296/#comment244375>
Typo: InfrManagerConstants instead of InfraManagerConstants
- Miklos Gergely
On April 10, 2017, 1:24 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58296/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 1:24 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20720
> https://issues.apache.org/jira/browse/AMBARI-20720
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add webapp infra-manager skeleton: add dependencies and basic configurations. (as its just skeleton, i added a lot of TODOs)
>
>
> Diffs
> -----
>
> ambari-infra/ambari-infra-manager/README.md PRE-CREATION
> ambari-infra/ambari-infra-manager/pom.xml PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfrManagerConstants.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerApiDocConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerConfig.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/log4j.xml PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/swagger/swagger.html PRE-CREATION
> ambari-infra/ambari-infra-manager/src/main/resources/webapp/index.html PRE-CREATION
> ambari-infra/pom.xml a6a6961
>
>
> Diff: https://reviews.apache.org/r/58296/diff/1/
>
>
> Testing
> -------
>
> done.
> with 'mvn clean package exec:java' you can start the web server
>
>
> Thanks,
>
> Oliver Szabo
>
>