[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13095: Allow to config Sasl configs in Kafka source

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#discussion_r768427724



##########
File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
##########
@@ -43,6 +43,49 @@
             "A comma-separated list of host and port pairs that are the addresses of "
           + "the Kafka brokers that a Kafka client connects to initially bootstrap itself")
     private String bootstrapServers;
+
+    @FieldDoc(
+            required = false,
+            defaultValue = "",
+            help = "Protocol used to communicate with kafka brokers.")

Review comment:
       ```suggestion
               help = "Protocol used to communicate with Kafka brokers.")
   ```
   Capitalize proper nouns correctly. Pls check all occurrences.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org