You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/07/05 12:13:22 UTC
[GitHub] flink pull request #6265: [FLINK-9765] [sql-client] Improve CLI responsivene...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/6265
[FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable
## What is the purpose of the change
Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. The result of the cancellation is not used anyway.
## Brief change log
Moves the job cancellation into the phase of the refresh thread
## Verifying this change
Manually verified.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-9765
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6265
----
commit 8204ae6e2a638b6c9f0d093bcd35b7710b0dbf61
Author: Timo Walther <tw...@...>
Date: 2018-07-05T11:25:28Z
[FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable
----
---
[GitHub] flink issue #6265: [FLINK-9765] [sql-client] Improve CLI responsiveness when...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6265
+1
---
[GitHub] flink issue #6265: [FLINK-9765] [sql-client] Improve CLI responsiveness when...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6265
+1
---
[GitHub] flink pull request #6265: [FLINK-9765] [sql-client] Improve CLI responsivene...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6265
---
[GitHub] flink issue #6265: [FLINK-9765] [sql-client] Improve CLI responsiveness when...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6265
Thank you @yanghua and @zentol. Merging this...
---