You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/30 20:30:21 UTC

[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

pabloem commented on pull request #11582:
URL: https://github.com/apache/beam/pull/11582#issuecomment-622092973


   This is looking good. Something I think we should do is change the underlying implementation of ReadFromBigQuery 
   
   ```
   class ReadFromBQ:
     def expand(self):
       return Create([self.input_element]) | ReadAllFromBigQuery()
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org