You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/10/09 01:02:29 UTC
[kudu-CR] [java] fixed kudu-jepsen build
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11622
Change subject: [java] fixed kudu-jepsen build
......................................................................
[java] fixed kudu-jepsen build
The code in client.clj and table.clj in the kudu-jepsen package were
importing BaseKuduTest but didn't use it. After the recent changes,
the Clojure build cannot import BaseKuduTest anymore. Since it was
unused anyway, I decided to stop importing the useless stuff without
digging in further. That fixed the build error.
This is a follow-up to dc8ae79961f71b8bdc344781fc89d38d94152fc4.
Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/11622/1
--
To view, visit http://gerrit.cloudera.org:8080/11622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Gerrit-Change-Number: 11622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [java] fixed kudu-jepsen build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11622 )
Change subject: [java] fixed kudu-jepsen build
......................................................................
Patch Set 1: Verified+1
Unrelated flake in org.apache.kudu.backup.TestKuduBackup (known flake)
--
To view, visit http://gerrit.cloudera.org:8080/11622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Gerrit-Change-Number: 11622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 02:18:43 +0000
Gerrit-HasComments: No
[kudu-CR] [java] fixed kudu-jepsen build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11622 )
Change subject: [java] fixed kudu-jepsen build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Gerrit-Change-Number: 11622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 02:29:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] fixed kudu-jepsen build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11622 )
Change subject: [java] fixed kudu-jepsen build
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Gerrit-Change-Number: 11622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java] fixed kudu-jepsen build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11622 )
Change subject: [java] fixed kudu-jepsen build
......................................................................
[java] fixed kudu-jepsen build
The code in client.clj and table.clj in the kudu-jepsen package were
importing BaseKuduTest but didn't use it. After the recent changes,
the Clojure build cannot import BaseKuduTest anymore. Since it was
unused anyway, I decided to stop importing the useless stuff without
digging in further. That fixed the build error.
This is a follow-up to dc8ae79961f71b8bdc344781fc89d38d94152fc4.
Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Reviewed-on: http://gerrit.cloudera.org:8080/11622
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d88b55a5f0b3ef4bf683d1de1bddc090d351b56
Gerrit-Change-Number: 11622
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>