You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by wispy316 <gi...@git.apache.org> on 2017/10/13 08:40:05 UTC
[GitHub] incubator-weex pull request #790: fix clipPath not works on android N 7.0
GitHub user wispy316 opened a pull request:
https://github.com/apache/incubator-weex/pull/790
fix clipPath not works on android N 7.0
@YorkShen
here is my polyfill. just judge the scaleX、scaleY and so on to fix。
the one with is broken at release-0.16。 see first yellow box. click it will do the animation.
fixed with the polyfill. clip child view works on the first yellow box.
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
<!--
How to use github markdown?
### checkable example
- [x] checked
- [ ] not checked
More github Markdown info to see https://guides.github.com/features/mastering-markdown/
-->
CheckList:
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
<!--
（请在***提交***前删除这段描述）
Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
Our new GitHub repo is https://github.com/apache/incubator-weex
After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
Thank you for your support.
----
注意：Weex 将于 2017-02-24 迁移至 Apache 基金会
届时我们会使用新的 GitHub 仓库：https://github.com/apache/incubator-weex 并在那里继续接受大家的 pull request。
更多详情请关注：https://github.com/weexteam/article/issues/130
感谢理解和支持
-->
<!--
（请在***提交***前删除这段描述）
It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large feature to `master` branch.
See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
----
错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支；
查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
-->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wispy316/incubator-weex feature-support-clippath-N
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/790.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #790
----
commit 15dd36a9f0315f61dd9823936e14f5f98a5548ac
Author: 行久 <yi...@alibaba-inc.com>
Date: 2017-10-12T10:08:09Z
fix clipPath not works on android N 7.0
----
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/790
@wispy316 thanks a lot for your pull request.
There are somethings wrong for all weex developers and users.
1. please not use alibaba local links that other people can't open,such as 'mtl.alibaba-inc.com','rax.alibaba-inc.com'.
2.By the way, if PR title is of the form [WEEX-xxxx], xxxx is the relevant JIRA number, it will be referenced to the JIRA issue automaticly.
have a better way to join weex.~
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/790
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by wispy316 <gi...@git.apache.org>.
Github user wispy316 commented on the issue:
https://github.com/apache/incubator-weex/pull/790
update url, @gurisxie @cxfeng1 @cxfeng1
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by wispy316 <gi...@git.apache.org>.
Github user wispy316 commented on the issue:
https://github.com/apache/incubator-weex/pull/790
https://issues.apache.org/jira/browse/WEEX-84
Demo:
http://rax.alibaba-inc.com/playground/1094b05a-0b0e-4ec3-a962-c91c8d22f21f
APK:
http://mtl.alibaba-inc.com/oss/mupp/55218/2785369/2785369/f46de55f54a9b9a251d8240640f2d840/taobao-android-debug.apk
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/790
The APK link can't be opened.
---
[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/790
has merge rebase ,but bot seems broken.
---
[GitHub] incubator-weex pull request #790: fix clipPath not works on android N 7.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/790
---