You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Kulp (JIRA)" <ji...@codehaus.org> on 2007/02/09 20:00:44 UTC

[jira] Created: (MRRESOURCES-6) Remote resources are not added to test jars

Remote resources are not added to test jars
-------------------------------------------

                 Key: MRRESOURCES-6
                 URL: http://jira.codehaus.org/browse/MRRESOURCES-6
             Project: Maven 2.x Remote Resources Plugin
          Issue Type: Bug
    Affects Versions: 1.0-alpha-1
            Reporter: Daniel Kulp
             Fix For: 1.0-alpha-2



Generated remote-resources should also be added to the test jar create with jar:test-jar.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRRESOURCES-6) Remote resources are not added to test jars

Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRRESOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp closed MRRESOURCES-6.
---------------------------------

         Assignee: Daniel Kulp
       Resolution: Fixed
    Fix Version/s: 1.0-alpha-2

Fixed in 505419

> Remote resources are not added to test jars
> -------------------------------------------
>
>                 Key: MRRESOURCES-6
>                 URL: http://jira.codehaus.org/browse/MRRESOURCES-6
>             Project: Maven 2.x Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-1
>            Reporter: Daniel Kulp
>         Assigned To: Daniel Kulp
>             Fix For: 1.0-alpha-2
>
>
> Generated remote-resources should also be added to the test jar create with jar:test-jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRRESOURCES-6) Remote resources are not added to test jars

Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRRESOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95002 ] 

Daniel Kulp commented on MRRESOURCES-6:
---------------------------------------


That is actually due to bug:
http://jira.codehaus.org/browse/SUREFIRE-300

If you just put a test scope dependency to junit, it should work fine.

Other option is to add:
    <properties>
        <maven.test.skip>true</maven.test.skip>
    </properties>

which would cause all the test stuff to skip entirely.


The main issue is that remote-resources doesn't really know if there ARE tests or not when it runs.   By default, it runs in generate-sources.   Tests could be created as part of generate-test-sources or similar.    




> Remote resources are not added to test jars
> -------------------------------------------
>
>                 Key: MRRESOURCES-6
>                 URL: http://jira.codehaus.org/browse/MRRESOURCES-6
>             Project: Maven 2.x Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-1
>            Reporter: Daniel Kulp
>            Assignee: Daniel Kulp
>             Fix For: 1.0-alpha-2
>
>
> Generated remote-resources should also be added to the test jar create with jar:test-jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRRESOURCES-6) Remote resources are not added to test jars

Posted by "Stefano Bagnara (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRRESOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95030 ] 

Stefano Bagnara commented on MRRESOURCES-6:
-------------------------------------------

The property solution works.
Btw IMHO it would be good if the plugin allow configurability on whether to apply the files to both main and tests or only to main (if this cannot be autodetermined)

> Remote resources are not added to test jars
> -------------------------------------------
>
>                 Key: MRRESOURCES-6
>                 URL: http://jira.codehaus.org/browse/MRRESOURCES-6
>             Project: Maven 2.x Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-1
>            Reporter: Daniel Kulp
>            Assignee: Daniel Kulp
>             Fix For: 1.0-alpha-2
>
>
> Generated remote-resources should also be added to the test jar create with jar:test-jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRRESOURCES-6) Remote resources are not added to test jars

Posted by "Stefano Bagnara (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRRESOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95001 ] 

Stefano Bagnara commented on MRRESOURCES-6:
-------------------------------------------

I think this should be done only if tests are really present.
Now there is a new bug: if the project does not have any test I have this error:
{code}
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] null
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.NullPointerException
        at org.apache.maven.plugin.surefire.SurefirePlugin.constructSurefireBooter(SurefirePlugin.java:594)
        at org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugin.java:391)
        at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
        at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
[INFO] ------------------------------------------------------------------------
{code}

And this is because the NOTICE and LICENSE have been copied in the output test folder and surefire thinks there are tests to be executed!

> Remote resources are not added to test jars
> -------------------------------------------
>
>                 Key: MRRESOURCES-6
>                 URL: http://jira.codehaus.org/browse/MRRESOURCES-6
>             Project: Maven 2.x Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-1
>            Reporter: Daniel Kulp
>            Assignee: Daniel Kulp
>             Fix For: 1.0-alpha-2
>
>
> Generated remote-resources should also be added to the test jar create with jar:test-jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira