[GitHub] [mesos] cf-natali commented on pull request #385: Fixed read of uninitialized variables detected with UBSAN.

[GitBox <gi...@apache.org>]

cf-natali commented on pull request #385:
URL: https://github.com/apache/mesos/pull/385#issuecomment-841736466


   @asekretenko Would it be possible to revert it?
   Since merging it I've noticed that I get some tests failing randomly - it's really strange, they are cgroup isolator tests which seem completely unrelated, e.g.:
   
   ```
   [ RUN      ] MesosContainerizerTest.StatusWithContainerID
   ../../src/tests/mesos.cpp:736: Failure
   Failed to wait 15secs for cgroups::destroy(hierarchy, cgroup)
   -----------------------------------------------------------
   We're very sorry but we can't seem to destroy existing
   cgroups that we likely created as part of an earlier
   invocation of the tests. Please manually destroy the cgroup
   at '/sys/fs/cgroup/memory/mesos_test_92a75d38-a749-4894-9746-79f8b3590b7c/57721582-cd4d-43a7-8fcf-0b57e26a7987' by first
   manually killing all the processes found in the file at '/sys/fs/cgroup/memory/mesos_test_92a75d38-a749-4894-9746-79f8b3590b7c/57721582-cd4d-43a7-8fcf-0b57e26a7987/tasks'
   -----------------------------------------------------------
   ../../src/tests/mesos.cpp:782: Failure
   Failed to wait 15secs for cgroups::destroy(hierarchy, cgroup)
   [  FAILED  ] MesosContainerizerTest.StatusWithContainerID (30062 ms)
   ```
   
   I have no idea what's going on, the only explanation I can see is that somehow before because these variables where not initialised they were pretty much always `true` (non-0 bool) and somehow the tests might depend on it.
   I'll try to understand what causes it but in the meantime probably best to revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org