You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/05/08 01:44:25 UTC

Review Request 66998: ATLAS-2655: Restrict category children to be within same glossary

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66998/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2655
    https://issues.apache.org/jira/browse/ATLAS-2655


Repository: atlas


Description
-------

Current behavior allows cross glossary hierarchy creation. This change adds a restriction to only allow children from same glossary.


Diffs
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9d6d73df1 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java 17460817d 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 7ffbef4e3 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java e9efc7737 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java de22d38e9 


Diff: https://reviews.apache.org/r/66998/diff/1/


Testing
-------

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/355/


Thanks,

Apoorv Naik


Re: Review Request 66998: ATLAS-2655: Restrict category children to be within same glossary

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66998/#review202613
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 8, 2018, 1:44 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66998/
> -----------------------------------------------------------
> 
> (Updated May 8, 2018, 1:44 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2655
>     https://issues.apache.org/jira/browse/ATLAS-2655
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Current behavior allows cross glossary hierarchy creation. This change adds a restriction to only allow children from same glossary.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9d6d73df1 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java 17460817d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 7ffbef4e3 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java e9efc7737 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java de22d38e9 
> 
> 
> Diff: https://reviews.apache.org/r/66998/diff/1/
> 
> 
> Testing
> -------
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/355/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>