You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Guenter Knauf <fu...@apache.org> on 2007/01/22 18:49:56 UTC

Re: [PATCH] enable another basedir during 'make install' forNetWare

Hi Brad,
>     Can you split this patch up into httpd, apr and apr-util and also
>     create the diff file against trunk rather than 2.4?  Since this patch
done:
http://www.gknw.net/test/httpd_patches/httpd_makefiles.diff
http://www.gknw.net/test/httpd_patches/2_mkconfNW.awk.diff
http://www.gknw.net/test/httpd_patches/apr_makefiles.diff
http://www.gknw.net/test/httpd_patches/apr-util_makefiles.diff

>     spans all three projects, we are probably going to have a problem
>     coordinating releases.  So at the very least, can you make sure that
>     each project builds properly without the BASEDIR env variable so that
>     it doesn't break the current build process for NetWare?
I think it cant break. If you look at apr\build\NWGNUenvironment.inc you can see that apr uses INSTALLBASE, and that gets set in any case. That the test makefiles are affected is therefore an older outstanding issue, and the patch doesnt make it any more bad as it currently is - however I doubt that someone does a 'make install' for getting the test samples in place...
apr-util has no own build files at all, and therefore cant be build standalone, nor breaked.

thanks, Guenter.

Re: [PROPOSAL] use of SVN $id keyword

Posted by Guenter Knauf <fu...@apache.org>.

Hi Ruediger,

> Hm. I would like to hear some comments by the svn gurus on that. Questions
> that come
> up to my mind are:

> 1. What revision number will be shown in the tag: The revision number of
> the last
>    change of this file or the revision number that is actual at the point
>    of time
>    when I do 'svn up' on the directory (or a parent directory) in which
>    the file
>    is stored.
revision + date of last change of the file AFAICT.

> 2. Does this introduce 'pseudo modifications' of files, where the id tag
> gets updated
>    although I do not do any manual changes to the file?
dont understand this; of course it gets updated once while inserting the id tag for first time; after that no more.

> 3. At which point of time the "$id tag" gets expanded / updated? Directly
> after the commit?
yes, I think so - after I've commit the 'svn propset svn:keywords "Id" file' then my local files hold the expanded version.

> 4. What is stored in the repository "$id $" or its expanded version?
$id $; this is some downside since I guess that viewcvs always will show the $id $ only, and not the expanded version - but this might be a setting in viewcvs? I dont know, but can only tell what I found with other repos where I use the id.

greets, Guenter,

question about mod_dbd.c / apr_dbd.c

Posted by Guenter Knauf <fu...@apache.org>.

Hi all,
I was just trying to get the mod_dbd /apr_dbd stuff working for NetWare, and would like to make a suggestion regarding the DSO extension:
in apr_dbd.c we have this:
#ifdef WIN32
    sprintf(path, "apr_dbd_%s.dll", name);
#else
    apr_snprintf(path, sizeof path, APU_DSO_LIBDIR "/apr_dbd_%s.so", name);
#endif

there I'm asking me why for Win32 we have '.dll' extension although the modules are named '.so' as on Unix?
Anyway, for NetWare we need '.nlm' since our compiler is too stupid to deal properly with '.so'.
Then I see in mod_dbd.c this:
            return apr_psprintf(cmd->pool,
                                "DBD: Can't load driver file apr_dbd_%s.so",
                                cfg->name);

so here we print out '.so' extension conditionless.
Therefore I want to suggest to introduce a new define for apr.h, f.e.
#define APR_DSO_EXT "so"
and for NetWare we can then use:
#define APR_DSO_EXT "nlm"
for Win32 I'd suggest that we constantly use "so" too since the modules have this ending already....

please let me know if you agree with that or not so that I can prepare the proper patches.

thanks, Guenter.

Re: [PATCH] add experimental modules makefiles for NetWare

Posted by Guenter Knauf <fu...@apache.org>.

Hi,
> Already done in trunk.  I still need to add them to 2.2 branch
thanks!

Guenter.

Re: [PATCH] add experimental modules makefiles for NetWare

Posted by Brad Nicholes <BN...@novell.com>.

>>> On 3/9/2007 at 11:22 AM, in message
<Wr...@akmail>, Guenter Knauf
<fu...@apache.org> wrote:
> Hi Brad,
> can you please commit the attached makefiles to the 'experimental' modules 
> folder, 
> and patch the existing NWGNUmakefile in order to pick up the new ones?
> Since its no code change probably also for the 2.2.x line?
> 
> thanks, Guenter

Already done in trunk.  I still need to add them to 2.2 branch

Brad

[PATCH] add experimental modules makefiles for NetWare

Posted by Guenter Knauf <fu...@apache.org>.

Hi Brad,
can you please commit the attached makefiles to the 'experimental' modules folder, 
and patch the existing NWGNUmakefile in order to pick up the new ones?
Since its no code change probably also for the 2.2.x line?

thanks, Guenter.

[FG-Spam***** ] [PATCH] add experimental modules makefiles for NetWare

Posted by Guenter Knauf <fu...@apache.org>.

Hi Brad,
can you please commit the attached makefiles to the 'experimental' modules folder, 
and patch the existing NWGNUmakefile in order to pick up the new ones?
Since its no code change probably also for the 2.2.x line?

thanks, Guenter.

[PATCH] add access_compat_module to httpd.conf for NetWare

Posted by Guenter Knauf <fu...@apache.org>.

Hi Brad,
can you please apply the attached patch to trunk;
it adds the LoadModule statement for the access_compat_module to httpd.conf.

thanks, Guenter.