You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/12/14 08:02:12 UTC
[kudu-CR] [jepen.kudu] some updates
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5500
Change subject: [jepen.kudu] some updates
......................................................................
[jepen.kudu] some updates
Updated jepsen.kudu test scenarios:
* More robust NTP-related operations
* Added additional nemeses
* README.md: added notes on Docker for Mac
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/README.md
M java/kudu-jepsen/project.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
6 files changed, 254 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/1
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [jepsen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#5).
Change subject: [jepsen.kudu] some updates
......................................................................
[jepsen.kudu] some updates
Updated jepsen.kudu test scenarios:
* More robust NTP-related operations
* Added additional nemeses
* README.md: added notes on Docker for Mac
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/README.md
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
5 files changed, 235 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/5
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [jepen.kudu] some updates
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5500/2/java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj:
PS2, Line 24: m
> I think the convention in clojure is to align 1 column to the right, so tha
ok, I see. However, in jepsen sources it's like that (i.e. no separate column for the opening double-quote). Also, vim does this as well. I'll take a look at other places -- probably, jepsen and vim are both using some other style.
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] run tests from the clojure-maven-plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#9).
Change subject: [jepsen.kudu] run tests from the clojure-maven-plugin
......................................................................
[jepsen.kudu] run tests from the clojure-maven-plugin
This patch adds functionality to run the kudu-jepsen tests
from the clojure-maven-plugin. To run the tests against already
provisioned Kudu cluster with master node m0 and tserver nodes {t0..t4},
execute the following in the $REPO_ROOT/java/kudu-jepsen directory:
mvn test -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4"
after bulding the top-level project with
mvn compile -Pjepsen
Besides, this patch contains additional updates on kudu-jepsen code and
the scenarios for the read/write register linearizability test:
* Added additional nemeses
* Run multiple test scenarios in the scope of the register test
* Starting up master server: wait for the catalog manager
* Other unsorted fixes for more robust operation
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/.gitignore
A java/kudu-jepsen/README.adoc
D java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
12 files changed, 851 insertions(+), 169 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/9
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepsen.kudu] run tests from the clojure-maven-plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#8).
Change subject: [jepsen.kudu] run tests from the clojure-maven-plugin
......................................................................
[jepsen.kudu] run tests from the clojure-maven-plugin
This patch adds functionality to run the kudu-jepsen tests
from the clojure-maven-plugin. To run the tests against already
provisioned Kudu cluster with master node m0 and tserver nodes {t0..t4},
execute the following in the $REPO_ROOT/java/kudu-jepsen directory:
mvn test -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4"
after bulding the top-level project with
mvn compile -Pjepsen
Besides, this patch contains additional updates on kudu-jepsen code and
the scenarios for the read/write register linearizability test:
* Added additional nemeses
* Run multiple test scenarios in the scope of the register test
* Starting up master server: wait for the catalog manager
* Other unsorted fixes for more robust operation
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/.gitignore
A java/kudu-jepsen/README.adoc
D java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
12 files changed, 845 insertions(+), 169 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/8
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [jepen.kudu] some updates
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5500/2//COMMIT_MSG
Commit Message:
PS2, Line 7: epen
> jepsen
Done
http://gerrit.cloudera.org:8080/#/c/5500/2/java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj:
PS2, Line 24: m
> Ah ok - if this is consistent with Jepsen then that's fine with me.
After some research I can say that the way it's written here is the default clojure style -- one can find that in core clojure functions and other references such as 'Clojure for the brave and true' at http://www.braveclojure.com/
As for repl, that the snippet:
aserbin-MBP:kudu aserbin$ lein repl
nREPL server started on port 57993 on host 127.0.0.1 - nrepl://127.0.0.1:57993
REPL-y 0.3.7, nREPL 0.2.12
Clojure 1.8.0
Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14
Docs: (doc function-name-here)
(find-doc "part-of-name-here")
Source: (source function-name-here)
Javadoc: (javadoc java-object-or-class-here)
Exit: Control+D or (exit) or (quit)
Results: Stored in vars *1, *2, *3, an exception in *e
user=> (source clojure.test/run-tests)
(defn run-tests
"Runs all tests in the given namespaces; prints results.
Defaults to current namespace if none given. Returns a map
summarizing test results."
{:added "1.1"}
([] (run-tests *ns*))
([& namespaces]
(let [summary (assoc (apply merge-with + (map test-ns namespaces))
:type :summary)]
(do-report summary)
summary)))
nil
user=>
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#4).
Change subject: [jepsen.kudu] some updates
......................................................................
[jepsen.kudu] some updates
Updated jepsen.kudu test scenarios:
* More robust NTP-related operations
* Added additional nemeses
* README.md: added notes on Docker for Mac
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/README.md
M java/kudu-jepsen/project.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
6 files changed, 242 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/4
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepsen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [jepsen.kudu] some updates
......................................................................
Patch Set 5:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5500/5/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:
> Glad to see this filled out, though we should still update the rest (especi
That's fixed in https://gerrit.cloudera.org/#/c/5551
PS5, Line 12: The Knossos take
> "Knossos takes"
Done
PS5, Line 19: MacOS X
> "macOS"
Done
PS5, Line 23: xhyve
> Is this a typo or a real thing?
https://github.com/mist64/xhyve
PS5, Line 24: their clock, which is managed by their own NTP servers,
> "their clock (which is managed by their own NTP servers)"
Done
PS5, Line 25: their clock
> Drop
Done
PS5, Line 44: MacOS X
> "macOS"
Done
PS5, Line 50: MacOS X
> "macOS"
Done
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] run tests from the clojure-maven-plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#10).
Change subject: [jepsen.kudu] run tests from the clojure-maven-plugin
......................................................................
[jepsen.kudu] run tests from the clojure-maven-plugin
This patch adds functionality to run the kudu-jepsen tests
from the clojure-maven-plugin. To run the tests against already
provisioned Kudu cluster with master node m0 and tserver nodes {t0..t4},
execute the following in the $REPO_ROOT/java/kudu-jepsen directory:
mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4"
after bulding the top-level project with
mvn compile -Pjepsen
Besides, this patch contains additional updates on kudu-jepsen code and
the scenarios for the read/write register linearizability test:
* Added additional nemeses
* Run multiple test scenarios in the scope of the register test
* Starting up master server: wait for the catalog manager
* Other unsorted fixes for more robust operation
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/.gitignore
A java/kudu-jepsen/README.adoc
D java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
12 files changed, 844 insertions(+), 169 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/10
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepsen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#6).
Change subject: [jepsen.kudu] some updates
......................................................................
[jepsen.kudu] some updates
Updated jepsen.kudu test scenarios:
* More robust NTP-related operations
* Added additional nemeses
* README.md: added notes on Docker for Mac
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/README.md
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
5 files changed, 235 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/6
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepen.kudu] some updates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#3).
Change subject: [jepen.kudu] some updates
......................................................................
[jepen.kudu] some updates
Updated jepsen.kudu test scenarios:
* More robust NTP-related operations
* Added additional nemeses
* README.md: added notes on Docker for Mac
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/README.md
M java/kudu-jepsen/project.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
6 files changed, 242 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/3
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepsen.kudu] run tests from clojure-maven-plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#7).
Change subject: [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................
[jepsen.kudu] run tests from clojure-maven-plugin
Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin. To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4"
Also updated jepsen.kudu test scenarios:
* Added additional nemeses
* Starting up master server: wait for the catalog manager
* Run multiple test scenarios in the scope of the register test
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/.gitignore
A java/kudu-jepsen/README.adoc
D java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
12 files changed, 823 insertions(+), 168 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/7
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepsen.kudu] run tests from the clojure-maven-plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [jepsen.kudu] run tests from the clojure-maven-plugin
......................................................................
Abandoned
Abandoned in the favor of https://gerrit.cloudera.org/#/c/5492/
Reason: squashed David's initial patch with this one.
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [jepen.kudu] some updates
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [jepen.kudu] some updates
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5500/2//COMMIT_MSG
Commit Message:
PS2, Line 7: epen
jepsen
http://gerrit.cloudera.org:8080/#/c/5500/2/java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj:
PS2, Line 24: m
I think the convention in clojure is to align 1 column to the right, so that the opening double-quote is in its own column.
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] some updates
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [jepsen.kudu] some updates
......................................................................
Patch Set 5:
(8 comments)
Again, just skimmed, looking at infrastructure.
http://gerrit.cloudera.org:8080/#/c/5500/5/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:
Glad to see this filled out, though we should still update the rest (especially the FIXME sections).
PS5, Line 12: The Knossos take
"Knossos takes"
PS5, Line 19: MacOS X
"macOS"
PS5, Line 23: xhyve
Is this a typo or a real thing?
PS5, Line 24: their clock, which is managed by their own NTP servers,
"their clock (which is managed by their own NTP servers)"
PS5, Line 25: their clock
Drop
PS5, Line 44: MacOS X
"macOS"
PS5, Line 50: MacOS X
"macOS"
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [jepen.kudu] some updates
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [jepen.kudu] some updates
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5500/2/java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
File java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj:
PS2, Line 24: m
> ok, I see. However, in jepsen sources it's like that (i.e. no separate col
Ah ok - if this is consistent with Jepsen then that's fine with me.
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes