You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/26 07:29:15 UTC
[GitHub] [airflow] xingularity opened a new pull request #18524: doc: Added notification into this guide to help developer solve "dock…
xingularity opened a new pull request #18524:
URL: https://github.com/apache/airflow/pull/18524
Added notifications into CONTRIBUTORS_USER_QUICKSTART to help developers when they encounter docker credential error.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#discussion_r716160898
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -1110,14 +1112,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
-Note: If you encounter an error like "docker.credentials.errors.InitializationError:
-docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
+.. note::
+ If you encounter an error like "docker.credentials.errors.InitializationError:
+ docker-credential-secretservice not installed or not available in PATH", you may execute the following command to fix it:
Review comment:
Actually for Contributors quick start we should rely on what GitHub does for rendering. We do not build it as part of our documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#discussion_r716160697
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -1110,14 +1112,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
-Note: If you encounter an error like "docker.credentials.errors.InitializationError:
-docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
+.. note::
+ If you encounter an error like "docker.credentials.errors.InitializationError:
+ docker-credential-secretservice not installed or not available in PATH", you may execute the following command to fix it:
Review comment:
```suggestion
.. note::
If you encounter an error like "docker.credentials.errors.InitializationError:
docker-credential-secretservice not installed or not available in PATH", you may execute the following command to fix it:
```
I _think_ an empty line is needed? (Feel free to ignore this if Sphinx renders it correctly for you.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#issuecomment-927255824
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#issuecomment-927251344
Also: Could you reformat the commit message to conform to the general Git commit format?
See: https://robertcooper.me/post/git-commit-messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18524:
URL: https://github.com/apache/airflow/pull/18524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#issuecomment-927258049
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#issuecomment-927249998
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#discussion_r716158618
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -1101,6 +1110,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
+Note: If you encounter an error like "docker.credentials.errors.InitializationError:
+docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
+
+.. code-block:: bash
+
+ $ sudo apt install golang-docker-credential-helper
Review comment:
```suggestion
$ sudo apt install golang-docker-credential-helper
```
I think 2 spaces is not enough? (Not sure)
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -1101,6 +1110,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
+Note: If you encounter an error like "docker.credentials.errors.InitializationError:
+docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
Review comment:
```suggestion
.. note::
If you encounter an error like "docker.credentials.errors.InitializationError:
docker-credential-secretservice not installed or not available in PATH", you may
execute the following command to fix it.
```
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -287,6 +287,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
+Note: If you encounter an error like "docker.credentials.errors.InitializationError:
+docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
Review comment:
```suggestion
docker-credential-secretservice not installed or not available in PATH", you may execute the following command to fix it:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18524: doc: Added notification into this guide to help developer solve "dock…
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18524:
URL: https://github.com/apache/airflow/pull/18524#discussion_r716162855
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -1110,14 +1112,15 @@ Setting up Breeze
$ ./breeze --python 3.8 --backend mysql
-Note: If you encounter an error like "docker.credentials.errors.InitializationError:
-docker-credential-secretservice not installed or not available in PATH", you may execute following command to fix it.
+.. note::
+ If you encounter an error like "docker.credentials.errors.InitializationError:
+ docker-credential-secretservice not installed or not available in PATH", you may execute the following command to fix it:
Review comment:
Never mind this then. GitHub renders fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org