You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by rthille <gi...@git.apache.org> on 2014/12/10 21:23:51 UTC
[GitHub] thrift pull request: THRIFT-2883 Fix dict changed size during iter...
GitHub user rthille opened a pull request:
https://github.com/apache/thrift/pull/314
THRIFT-2883 Fix dict changed size during iteration exception
During the notification of outstanding requests via errback that the
connection has failed, new requests can be attempted which change
the size of the client._reqs dict. This change uses a temp variable
to hold the old dict, and resets client._reqs to a new, empty dict.
Also, it iterates until the new dict does not have any requests added
by the errbacks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rthille/thrift THRIFT-2883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #314
----
commit 55a86f53c05d243258f01037778fad20d53d070b
Author: Robert Thille <ro...@cyaninc.com>
Date: 2014-12-10T20:16:01Z
THRIFT-2883 Fix dict changed size during iteration exception
During the notification of outstanding requests via errback that the
connection has failed, new requests can be attempted which change
the size of the client._reqs dict. This change uses a temp variable
to hold the old dict, and resets client._reqs to a new, empty dict.
Also, it iterates until the new dict does not have any requests added
by the errbacks.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2883 Fix dict changed size during iter...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---